New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627601 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

InfoBarBackground::PaintMd doesn't work well for fractional scales

Project Member Reported by est...@chromium.org, Jul 12 2016

Issue description

It seems InfoBarBackground::PaintMd doesn't work well for fractional scales  when there's a detached bookmark bar. It works fine when there's an attached bookmark bar.
 

Comment 1 by bsep@chromium.org, Jul 14 2016

Are you talking about the black gap underneath the toolbar, like this this screenshot?
butterbar.PNG
34.0 KB View Download

Comment 2 by bsep@chromium.org, Jul 14 2016

Cc: bsep@chromium.org

Comment 3 by est...@chromium.org, Jul 14 2016

yep. Thanks for the screenshot. I believe (but am not certain) InfoBarBackground::PaintMd is the culprit.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21e70f121e72154c9891b061e9724ef30e1aecb9

commit 21e70f121e72154c9891b061e9724ef30e1aecb9
Author: estade <estade@chromium.org>
Date: Thu Jul 28 22:25:46 2016

Fix infobar painting issues at fractional scales

This calculates the paths for the infobar background (which paints the arrow) with the scale factor taken into account. It fixes blurriness in the arrow as well as a gap above the infobar (you can see both issues in a screenshot in the linked bug report).

It should have no impact on whole number DSFs (1x, 2x, etc)

BUG= 627601 

Review-Url: https://codereview.chromium.org/2179643002
Cr-Commit-Position: refs/heads/master@{#408498}

[modify] https://crrev.com/21e70f121e72154c9891b061e9724ef30e1aecb9/chrome/browser/ui/views/frame/browser_view_layout.cc
[modify] https://crrev.com/21e70f121e72154c9891b061e9724ef30e1aecb9/chrome/browser/ui/views/infobars/infobar_background.cc

Cc: kavvaru@chromium.org
Labels: Needs-Feedback
Tested the issue on windows 7 and windows 10(Hi dpi) using chrome version 54.0.2816.0.Still observed gap between toolbar and info bar.Observed the same behaviour with flag --top-chrome-md=material as well.

estade @ Please find the attached screen shot and confirm anything missed here.please provide us any expected screen shot verify from our end.

Thanks,




627601.png
138 KB View Download
That screenshot looks good but it is taken at 1x dsf. You want to test at 1.5x.
Retested the issue at 1.5x using the flag --force-device-scale-factor=1.5 on Win 10 [54.0.2816.0]
Please find the attached screen shots.
627601 with scaling set to 1.5.PNG
124 KB View Download
627601 with no scaling set.PNG
140 KB View Download
Status: Verified (was: Assigned)
looks right

Sign in to add a comment