The document.write evaluator is in standard preloads critical path. |
||||||
Issue descriptionThe logic in HTMLDocumentParser evaluates document.write scripts first, then deals with standard preloads. This ordering should be reversed, as the evaluator can add extra delay to fetching the standard preloads.
,
Jul 13 2016
Reading the motivation for this bug, I was wondering: does the evaluator still add delay in this new ordering (e.g. to the next parsing step)? If so, do we have data on how much latency is added? Would it be useful to do a dummy experiment where the evaluator doesn't trigger any additional preload to know its baseline cost?
,
Jul 13 2016
Yes we know exactly how much latency is added (usually 0-1ms for evaluating and ~5ms for initializing the context). This is in PreloadScanner.* histograms. Your suggestion to add another experiment group is a good idea. +bmcquade, WDYT? Also requesting a merge on this so it goes out asap.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0 commit 9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0 Author: csharrison <csharrison@chromium.org> Date: Wed Jul 13 04:45:18 2016 Move document.write evaluation after standard preloads This patch moves document.write evaluation to take place after all the preloads the HTMLDocumentParser knows about are fetched. This shaves off preload delay when the evaluator is busy evaluating or initializing the context. BUG= 627575 Review-Url: https://codereview.chromium.org/2146673002 Cr-Commit-Position: refs/heads/master@{#405026} [modify] https://crrev.com/9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39e2ca00a9b1c57902509ad191848a9cd180b7c8 commit 39e2ca00a9b1c57902509ad191848a9cd180b7c8 Author: csharrison <csharrison@chromium.org> Date: Thu Jul 14 18:20:33 2016 Move document.write evaluation after standard preloads This patch moves document.write evaluation to take place after all the preloads the HTMLDocumentParser knows about are fetched. This shaves off preload delay when the evaluator is busy evaluating or initializing the context. BUG= 627575 Review-Url: https://codereview.chromium.org/2146673002 Cr-Commit-Position: refs/heads/master@{#405026} (cherry picked from commit 9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0) TBR=kouhei@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2148363002 Cr-Commit-Position: refs/branch-heads/2785@{#120} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/39e2ca00a9b1c57902509ad191848a9cd180b7c8/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
,
Jul 18 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 13 2016