New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627568 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jan 2017
Cc:
█ xlai@chromium.org
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rebaseline-o-matic and display_list_2d_canvas tests

Project Member Reported by engedy@chromium.org, Jul 12 2016 
Not sure if this is specific to `display_list_2d_canvas` tests, or generic flakiness, but the following happened today:

1.) https://codereview.chromium.org/2130063002 landed, adding a new layout test `fast/canvas/canvas-pattern-no-repeat-with-transformations.html`, alongside the following line in TestExpectations:

 crbug.com/602509  virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-re
      peat-with-transformations.html [ NeedsRebaseline ]

2.) Rebaseline-o-matic prepared https://codereview.chromium.org/2139023003. This created expectations such as 	third_party/WebKit/LayoutTests/platform/linux/virtual/display_list_2d_canvas/fast/canvas/image-object-in-canvas-expected.png, but the same was not created for `linux-precise`.

3.) Subsequent continuous build failed on:

virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-repeat-with-transformations.html

4.) Running a webkit-patch rebaseline locally, however, created:

platform/linux-precise/virtual/display_list_2d_canvas/fast/canvas/canvas-pattern-no-repeat-with-transformations-expected.png

5.) Landing that CL (https://codereview.chromium.org/2144703002) fixed continuous build.

Comment 1 by engedy@chromium.org, Jul 12 2016 

In Step 3 it failed on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/67325, where the slave is running Precise.

Comment 2 by jeffcarp@chromium.org, Jan 30 2017

Cc: qyears...@chromium.org
Is this still an issue now that we've moved to Trusty?

Comment 3 by qyears...@chromium.org, Jan 31 2017

Status: WontFix (was: Untriaged)
It sounds like this may be a problem with rebaseline-o-matic, or it may no longer be an issue.

I think at this point, now that we have no more Precise builders and we might be able to deprecate rebaseline-o-matic in the not-too-distant future, I'd like to close this issue.

Note: There is another current bug about rebaseline-o-matic sometimes not fetching baselines as it should:  bug 676748 .
►

Sign in to add a comment