Gerrit already works for depot_tools, just CQ is missing.
The ACLs for Gerrit inherit from infra, so it's already same as infra, which is very good as nothing to be done.
Note: cq.cfg has already landed: https://codereview.chromium.org/2144723002
Sadly, i can't actually upload CLs to gerrit because depot_tools has Watchlists with emails like tandrii+omg_git_cl@, which Gerrit doesn't recognize.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/45f10aecb5b07e37f1a3064a511cdac2654b36d3 commit 45f10aecb5b07e37f1a3064a511cdac2654b36d3 Author: tandrii <tandrii@chromium.org> Date: Tue Jul 12 18:13:16 2016 Fix CQ.cfg for Gerrit. Follow up of https://codereview.chromium.org/2144723002. BUG= 627540 TBR=andybons@chromium.org Review-Url: https://codereview.chromium.org/2139603004 [modify] https://crrev.com/45f10aecb5b07e37f1a3064a511cdac2654b36d3/infra/config/cq.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/8e1f2d991566bd42b233ba822da106e1f0c418c1 commit 8e1f2d991566bd42b233ba822da106e1f0c418c1 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Jul 12 18:26:05 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/45f10aecb5b07e37f1a3064a511cdac2654b36d3 Fix CQ.cfg for Gerrit. (tandrii@chromium.org) R=andybons@chromium.org,tandrii@chromium.org BUG= 627540 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2143723002 [modify] https://crrev.com/8e1f2d991566bd42b233ba822da106e1f0c418c1/infra/config/recipes.cfg
Would it be more accurate to say that this is blocked by https://bugs.chromium.org/p/gerrit/issues/detail?id=4192 instead? I expect the timeframe for resolving gerrit:4192 to be shorter than for gerrit:4134
You are absolutely right! Somehow I couldn't find my own FR :(
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/e672ae7f9081bae02344fbd54a977241b0323242 commit e672ae7f9081bae02344fbd54a977241b0323242 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Jul 12 18:49:55 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/8e1f2d991566bd42b233ba822da106e1f0c418c1 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/45f10aecb5b07e37f1a3064a511cdac2654b36d3 Fix CQ.cfg for Gerrit. (tandrii@chromium.org) R=phajdan.jr@chromium.org,tandrii@chromium.org,andybons@chromium.org,martiniss@chromium.org,recipe-roller@chromium.org BUG= 627540 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2146593003 [modify] https://crrev.com/e672ae7f9081bae02344fbd54a977241b0323242/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/af46120c99927f5040653c6aacd67ba200b292db commit af46120c99927f5040653c6aacd67ba200b292db Author: tandrii <tandrii@chromium.org> Date: Tue Jul 12 20:14:13 2016 Add depot_tools Gerrit presubmit expectations. This doesn't change anything, primarily to keep Gerrit CQ for depot_tools from breaking. R=andybons@chromium.org BUG= 627540 Review-Url: https://codereview.chromium.org/2139413002 [add] https://crrev.com/af46120c99927f5040653c6aacd67ba200b292db/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json [modify] https://crrev.com/af46120c99927f5040653c6aacd67ba200b292db/scripts/slave/recipes/run_presubmit.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/6b7e457dbfaf95ed839a2c998a485c97c8368ff3 commit 6b7e457dbfaf95ed839a2c998a485c97c8368ff3 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Jul 12 21:15:09 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/af46120c99927f5040653c6aacd67ba200b292db Add depot_tools Gerrit presubmit expectations. (tandrii@chromium.org) https://crrev.com/9125e9a79cfe8e00866878454fb963c7a795c763 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/6b410ec4717c586b99958c83931bfb2a531627cc Gerrit CQ will not allow customization of CQ label values. (tandrii@chromium.org) R=phajdan.jr@chromium.org,recipe-roller@chromium.org,andybons@chromium.org,martiniss@chromium.org,tandrii@chromium.org BUG= 627540 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2134363003 [modify] https://crrev.com/6b7e457dbfaf95ed839a2c998a485c97c8368ff3/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/97d011eea72f220d2c846ae0b548c851fb3278ed commit 97d011eea72f220d2c846ae0b548c851fb3278ed Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Jul 12 21:39:54 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/af46120c99927f5040653c6aacd67ba200b292db Add depot_tools Gerrit presubmit expectations. (tandrii@chromium.org) https://crrev.com/9125e9a79cfe8e00866878454fb963c7a795c763 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/14b48c6e398ed5ecb81f5d543ae227dff1ce0379 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/0e72cff77e702c15c3f895eeec65f2c1ae1df100 Return device status check value (martiniss@chromium.org) https://crrev.com/bf4097c14d3ac30e68dc3bc146bfb759f1d5e5bf Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/6b410ec4717c586b99958c83931bfb2a531627cc Gerrit CQ will not allow customization of CQ label values. (tandrii@chromium.org) https://crrev.com/4b9967207bac106fe0530de9ac7307eecaf599b5 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/c290ab04d47180ed87f074026fae4392198fb8cf Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/25f1dc303679bede1c794106c1541186a2e648af Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/774c69370e740a8a5c85dce90f88a2bbd11911f5 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org) https://crrev.com/c3683107b331a0f9f0392c0a376ecf8143b1e2ac Revert of shutil recipe_module: port chromium_utils rmtree implementation. (patchset #2 id:20001 of https://codereview.chromium.org/2146523003/ ) (tandrii@chromium.org) https://crrev.com/2b31483ac5f58781c138af391a35ccf3a3f63245 shutil recipe_module: port chromium_utils rmtree implementation. (tandrii@chromium.org) R=phajdan.jr@chromium.org,recipe-roller@chromium.org,andybons@chromium.org,martiniss@chromium.org,tandrii@chromium.org BUG= 584783 , 627540 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2137063005 [modify] https://crrev.com/97d011eea72f220d2c846ae0b548c851fb3278ed/infra/config/recipes.cfg
Comment 1 by tandrii@chromium.org
, Jul 12 2016Components: -Infra Infra>CQ
Labels: -Restrict-View-Google Proj-Gerrit-Migration
Owner: tandrii@chromium.org
Status: Started (was: Untriaged)