New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627522 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Unexpected permissions prompts for default extensions during Chrome first run

Project Member Reported by jawag@chromium.org, Jul 12 2016

Issue description

Chrome Version       : M54 Canary
URLs (if applicable) : N/A
Other browsers tested: N/A (Chrome extensions related)

What steps will reproduce the problem?
(1)Install Chrome M54 Canary on a new Win10 device (this one was Dell XPS 13)
(2)Launch Chrome for the first time without signing in
(3)Open the Chrome Menu (see attached screenshot)

What is the expected result?
(1) I shouldn't have permissions prompts for any extensions because I'm not signed in, and because default apps/extensions shouldn't trigger new permission prompts after updates

What happens instead?
(1) I see new permissions prompts for Google Drive and Google Docs Offline.

Please provide any additional information below. Attach a screenshot if
possible.

 
KPnHx5opfLt.png
400 KB View Download

Comment 1 by jawag@chromium.org, Jul 12 2016

Cc: ainslie@chromium.org
Cc: rpop@chromium.org rsch...@chromium.org
Labels: -Pri-2 Pri-1
Bumping to P1. 

Your first run of Chrome should not include an error state. Especially not an error state that asks you to "re-enable" things you never installed/enabled. 

One other detail about my setup: I had also installed 51 stable before installing canary.
Cc: mamir@chromium.org
+mamir.  I wouldn't be surprised if this is a result of removing the creation flags from pending extension info, since that would then mean that bundled extensions never got the "installed by default" flag.

Comment 4 by mamir@chromium.org, Jul 14 2016

Owner: mamir@chromium.org

Comment 5 by nepper@chromium.org, Jul 14 2016

Components: Services>SupervisedUser
Labels: ReleaseBlock-Beta M-53
Status: Started (was: Unconfirmed)
Likely happening on M53 already, so this will require a merge once fixed and landed on trunk. Please mark this bug as "Merge-Requested" once you confirmed the change to work on trunk.

Comment 6 by gov...@chromium.org, Jul 14 2016

M53 beta launch is coming soon.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Monday (07/18/16). Thank you.

Comment 7 by mamir@chromium.org, Jul 14 2016

It has my full attention and it's currently my top priority.

Comment 9 by mamir@chromium.org, Jul 15 2016

Fix has landed. (together with a unit test for this edgy case)

I will not have access to a Win 10 machine over the weekend.
However, I will try to test on Mac upon the next Canary release.
Once we have some coverage on Canary over the weekend and it's safe can you please request for to merge to M53(2785) branch.

Comment 11 by mamir@chromium.org, Jul 17 2016

I tested Canary version 54.0.2799.0 on Mac 10.11.5, and the issue is fixed there.
No permissions prompt are shown upon the first run.

Comment 12 by mamir@chromium.org, Jul 17 2016

Labels: Merge-Request-53

Comment 13 by dimu@google.com, Jul 17 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 18 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb006083710f482493a5643509fedc6f399cd4a

commit 7fb006083710f482493a5643509fedc6f399cd4a
Author: Marc Treib <treib@chromium.org>
Date: Mon Jul 18 08:19:34 2016

Adding the creation_flags back to pending_extension_info. Add a unit test to cover the case when an external extension is updated before being installed and make sure it retains the creation flags.

BUG= 627522 

Review-Url: https://codereview.chromium.org/2146963004
Cr-Commit-Position: refs/heads/master@{#405856}
(cherry picked from commit 0128d5a9b0a402cd85aa0ef409c73f3ad1df548c)

Review URL: https://codereview.chromium.org/2158753002 .

Cr-Commit-Position: refs/branch-heads/2785@{#175}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/pending_extension_info.cc
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/pending_extension_info.h
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/pending_extension_manager.cc
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/pending_extension_manager.h
[modify] https://crrev.com/7fb006083710f482493a5643509fedc6f399cd4a/chrome/browser/extensions/updater/extension_updater_unittest.cc

Comment 16 by mamir@chromium.org, Jul 18 2016

Status: Fixed (was: Started)

Comment 17 by ajha@chromium.org, Jul 19 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2785.21
Verified the merge on the latest M-53(53.0.2785.21 /2785@{212}) on Windows 10 and this is working as intended. Didn't observe any permission prompt under Wrench menu for Google Drive or Google Docs.


Marking this as Verified therefore.

Comment 18 by mbw@google.com, Jul 27 2016

Labels: OS-Chrome OS-Mac
Cc: sdantul...@chromium.org abod...@chromium.org rookrishna@chromium.org
Can we check this is fixed on todays build?
Status: Verified (was: Fixed)
Powerwashed device and added user account. Permission prompts are not seen.

Verified on ChromeOS M53 beta (8530.35.0, 53.0.2785.36)

Sign in to add a comment