Per dgozman, "We can merge devtools_discovery with devtools_http_handler. I don't think we have usecases for one, but not another anymore."
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcf3423ed3619dcf8005510650ea5c31ea995f79 commit fcf3423ed3619dcf8005510650ea5c31ea995f79 Author: pfeldman <pfeldman@chromium.org> Date: Wed Aug 24 23:58:55 2016 DevTools: merge devtools target with devtools host, part 1 BUG= 627517 TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2263843002 Cr-Commit-Position: refs/heads/master@{#414208} [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/android_webview/browser/aw_dev_tools_discovery_provider.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/android/dev_tools_discovery_provider_android.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/chrome_devtools_discovery_provider.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/device/devtools_android_bridge.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/devtools_target_impl.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/devtools_target_impl.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/devtools_targets_ui.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/resources/inspect/inspect.js [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/ui/webui/inspect_ui.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/chrome/browser/ui/webui/inspect_ui.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/components/devtools_discovery/basic_target_descriptor.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/components/devtools_discovery/basic_target_descriptor.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/components/devtools_discovery/devtools_discovery_manager.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/components/devtools_discovery/devtools_target_descriptor.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/shared_worker_devtools_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/browser/service_worker/service_worker_internals_ui.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/public/browser/devtools_external_agent_proxy_delegate.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/headless/lib/browser/headless_devtools_manager_delegate.h [modify] https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8fe6fb45b52bac74304ea4938c04809806bb577 commit d8fe6fb45b52bac74304ea4938c04809806bb577 Author: mohsen <mohsen@chromium.org> Date: Thu Aug 25 01:55:10 2016 Revert of DevTools: merge devtools target with devtools host, part 1 (patchset #11 id:200001 of https://codereview.chromium.org/2263843002/ ) Reason for revert: Caused compile errors on Linux ChromiumOS GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44628 Original issue's description: > DevTools: merge devtools target with devtools host, part 1 > > BUG= 627517 > TBR= > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79 > Cr-Commit-Position: refs/heads/master@{#414208} TBR=dgozman@chromium.org,asargent@chromium.org,skyostil@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 627517 Review-Url: https://codereview.chromium.org/2277473007 Cr-Commit-Position: refs/heads/master@{#414244} [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/android_webview/browser/aw_dev_tools_discovery_provider.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/android/dev_tools_discovery_provider_android.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/chrome_devtools_discovery_provider.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/device/devtools_android_bridge.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/devtools_target_impl.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/devtools_target_impl.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/devtools_targets_ui.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/resources/inspect/inspect.js [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/ui/webui/inspect_ui.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/chrome/browser/ui/webui/inspect_ui.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/components/devtools_discovery/basic_target_descriptor.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/components/devtools_discovery/basic_target_descriptor.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/components/devtools_discovery/devtools_discovery_manager.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/components/devtools_discovery/devtools_target_descriptor.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/shared_worker_devtools_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/browser/service_worker/service_worker_internals_ui.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/public/browser/devtools_external_agent_proxy_delegate.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/headless/lib/browser/headless_devtools_manager_delegate.h [modify] https://crrev.com/d8fe6fb45b52bac74304ea4938c04809806bb577/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a commit a9e7ddae8f1174e71c2e999eec4813ee24c1f41a Author: pfeldman <pfeldman@chromium.org> Date: Fri Aug 26 14:35:17 2016 DevTools: merge devtools target with devtools host, part 1 BUG= 627517 TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2263843002 Cr-Commit-Position: refs/heads/master@{#414707} [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/android_webview/browser/aw_dev_tools_discovery_provider.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/android/dev_tools_discovery_provider_android.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/chrome_devtools_discovery_provider.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/device/devtools_android_bridge.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/devtools_target_impl.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/devtools_target_impl.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/devtools_targets_ui.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/resources/inspect/inspect.js [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/ui/webui/inspect_ui.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/chrome/browser/ui/webui/inspect_ui.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/components/devtools_discovery/basic_target_descriptor.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/components/devtools_discovery/basic_target_descriptor.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/components/devtools_discovery/devtools_discovery_manager.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/components/devtools_discovery/devtools_target_descriptor.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/service_worker_devtools_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/service_worker_devtools_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/shared_worker_devtools_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/shared_worker_devtools_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/site_per_process_devtools_browsertest.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/browser/service_worker/service_worker_internals_ui.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/public/browser/devtools_external_agent_proxy_delegate.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/headless/lib/browser/headless_devtools_manager_delegate.h [modify] https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc5d788743bf2cbd574cec98cca8b11f9dee1609 commit bc5d788743bf2cbd574cec98cca8b11f9dee1609 Author: pfeldman <pfeldman@chromium.org> Date: Fri Aug 26 18:55:46 2016 DevTools: remove DevToolsTargetDescriptor and its implementations, we are now based on devtools agent hosts. BUG= 627517 TBR=this is a mechanical change Review-Url: https://codereview.chromium.org/2273063002 Cr-Commit-Position: refs/heads/master@{#414768} [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/android_webview/browser/aw_dev_tools_discovery_provider.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/android_webview/browser/aw_dev_tools_discovery_provider.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/android/dev_tools_discovery_provider_android.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/android/dev_tools_discovery_provider_android.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/BUILD.gn [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/chrome_devtools_discovery_provider.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/chrome_devtools_discovery_provider.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/device/devtools_android_bridge.h [delete] https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2/chrome/browser/devtools/devtools_target_impl.cc [delete] https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2/chrome/browser/devtools/devtools_target_impl.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/devtools_targets_ui.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/devtools_targets_ui.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/extensions/api/debugger/debugger_api.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/extensions/api/debugger/debugger_api.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/ui/webui/inspect_ui.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/browser/ui/webui/inspect_ui.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/chrome/chrome_debugger.gypi [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/components/devtools_discovery/BUILD.gn [delete] https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2/components/devtools_discovery/basic_target_descriptor.cc [delete] https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2/components/devtools_discovery/basic_target_descriptor.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/components/devtools_discovery/devtools_discovery_manager.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/components/devtools_discovery/devtools_discovery_manager.h [delete] https://crrev.com/e73e1a1f69d9ac7dc8216f930544aa5650d74ef2/components/devtools_discovery/devtools_target_descriptor.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/components/devtools_http_handler/devtools_http_handler.h [modify] https://crrev.com/bc5d788743bf2cbd574cec98cca8b11f9dee1609/content/shell/browser/shell_devtools_manager_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628 commit 43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628 Author: Pavel Feldman <pfeldman@chromium.org> Date: Tue Aug 30 00:04:35 2016 DevTools: remove devtools_discovery (merged into content). BUG= 627517 R=dgozman@chromium.org TBR=for android / headless / webview clients Review URL: https://codereview.chromium.org/2272213003 . Cr-Commit-Position: refs/heads/master@{#415041} [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/android_webview/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/android_webview/DEPS [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/android_webview/android_webview.gyp [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/android_webview/browser/aw_dev_tools_discovery_provider.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/android_webview/browser/aw_dev_tools_discovery_provider.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/android/DEPS [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/chrome/browser/android/dev_tools_discovery_provider_android.h [rename] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/android/devtools_manager_delegate_android.cc [add] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/android/devtools_manager_delegate_android.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/devtools/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/devtools/DEPS [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/chrome/browser/devtools/chrome_devtools_discovery_provider.cc [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/chrome/browser/devtools/chrome_devtools_discovery_provider.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/chrome_browser.gypi [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/chrome/chrome_debugger.gypi [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/components/OWNERS [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/components/devtools_discovery/BUILD.gn [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/components/devtools_discovery/DEPS [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/components/devtools_discovery/OWNERS [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/components/devtools_discovery/devtools_discovery_manager.cc [delete] https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e/components/devtools_discovery/devtools_discovery_manager.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/components/devtools_http_handler/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/components/devtools_http_handler/DEPS [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/content_shell.gypi [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/shell/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/shell/DEPS [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/extensions/shell/BUILD.gn [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/extensions/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/43f56b7c7e3fdbd2567c8c5a5a63b2bde70ce628/headless/lib/browser/headless_devtools_manager_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019 commit f1a1694bef83721d4a2e1bb9e6399e57a4e1a019 Author: pfeldman <pfeldman@chromium.org> Date: Fri Sep 02 21:28:00 2016 DevTools: simplify http handler delegate as it is moving into content. BUG= 627517 TBR= for handler clients. Review-Url: https://codereview.chromium.org/2295623002 Cr-Commit-Position: refs/heads/master@{#416345} [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/android_webview/native/aw_dev_tools_server.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/browser/android/dev_tools_server.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/browser/devtools/device/adb/mock_adb_server.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/browser/devtools/frontend/devtools_discovery_page.html [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/browser/devtools/remote_debugging_server.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/browser/devtools/remote_debugging_server.h [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chrome/test/data/devtools/target_list/background.js [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chromecast/browser/devtools/cast_dev_tools_delegate.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chromecast/browser/devtools/cast_dev_tools_delegate.h [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/chromecast/browser/devtools/remote_debugging_server.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/components/devtools_http_handler/devtools_http_handler.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/components/devtools_http_handler/devtools_http_handler.h [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/components/devtools_http_handler/devtools_http_handler_delegate.h [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/components/devtools_http_handler/devtools_http_handler_unittest.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/content/content_browser.gypi [add] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/content/public/browser/devtools_socket_factory.h [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/content/shell/browser/shell_devtools_frontend.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019/headless/lib/browser/headless_devtools.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1062876ae55867edab8ec43884e9b9e15d0fe451 commit 1062876ae55867edab8ec43884e9b9e15d0fe451 Author: pfeldman <pfeldman@chromium.org> Date: Thu Sep 08 07:59:26 2016 DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. BUG= 627517 TBR= changes to clients of the changed APIs. NOTRY=true (flaky try bot: https://codereview.chromium.org/2270333002). Review-Url: https://codereview.chromium.org/2300703005 Cr-Commit-Position: refs/heads/master@{#417223} [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/android_webview.gyp [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/browser/aw_browser_main_parts.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/browser/aw_content_browser_client.h [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/android_webview/browser/aw_dev_tools_discovery_provider.cc [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/android_webview/browser/aw_dev_tools_discovery_provider.h [add] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/browser/aw_devtools_manager_delegate.cc [add] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/browser/aw_devtools_manager_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/android_webview_jni_registrar.cc [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/aw_devtools_server.cc [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/aw_devtools_server.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/android_webview/native/webview_native.gyp [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/devtools_manager_delegate_android.h [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/devtools_server.cc [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/android/devtools_server.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/BUILD.gn [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/chrome/browser/devtools/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/remote_debugging_server.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chrome/browser/devtools/remote_debugging_server.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/cast_content_browser_client.h [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/chromecast/browser/devtools/cast_dev_tools_delegate.h [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/devtools/cast_devtools_delegate.cc [add] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/devtools/cast_devtools_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/devtools/remote_debugging_server.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/chromecast/browser/devtools/remote_debugging_server.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/components/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/components/OWNERS [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/components/devtools_http_handler/BUILD.gn [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/components/devtools_http_handler/DEPS [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/components/devtools_http_handler/OWNERS [delete] https://crrev.com/514060991bfac39c9001124ab4373b41974b41c4/components/devtools_http_handler/devtools_http_handler_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_agent_host_impl.h [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_http_handler.cc [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_http_handler.h [rename] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_http_handler_unittest.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_manager.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_manager.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/public/browser/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/public/browser/devtools_external_agent_proxy_delegate.h [add] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/public/browser/devtools_manager_delegate.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/browser/shell_browser_main_parts.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/browser/shell_browser_main_parts.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/browser/shell_devtools_frontend.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/browser/shell_devtools_manager_delegate.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/content/test/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/extensions/shell/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/extensions/shell/browser/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/extensions/shell/browser/shell_browser_main_parts.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/extensions/shell/browser/shell_browser_main_parts.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/BUILD.gn [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/DEPS [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_browser_main_parts.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_browser_main_parts.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_devtools.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_devtools.h [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_devtools_manager_delegate.cc [modify] https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451/headless/lib/browser/headless_devtools_manager_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779 commit dda2ff1de0b3ca84fda1e92c196d57c66b7d5779 Author: dgozman <dgozman@chromium.org> Date: Thu Sep 15 23:10:25 2016 [DevTools] Fix out of process iframes not working on chrome://inspect. Regressed in recent refactoring of devtools discovery. Added checks to existing tests. BUG= 627517 Review-Url: https://codereview.chromium.org/2332213010 Cr-Commit-Position: refs/heads/master@{#419030} [modify] https://crrev.com/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/dda2ff1de0b3ca84fda1e92c196d57c66b7d5779/content/browser/devtools/site_per_process_devtools_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e28eab4196fd3d2da875a39f89c3e83852ccd0af commit e28eab4196fd3d2da875a39f89c3e83852ccd0af Author: pfeldman <pfeldman@chromium.org> Date: Wed Sep 21 23:00:53 2016 DevTools: return discovered targets asynchronously. BUG= 627517 TBR= (interface changed) Review-Url: https://codereview.chromium.org/2344753002 Cr-Commit-Position: refs/heads/master@{#420189} [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/android_webview/browser/aw_devtools_manager_delegate.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/chrome/browser/android/devtools_manager_delegate_android.h [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/browser/devtools/devtools_http_handler.h [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/browser/devtools/protocol/browser_handler.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/browser/devtools/protocol/browser_handler.h [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/public/browser/devtools_manager_delegate.cc [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/content/public/browser/devtools_manager_delegate.h [modify] https://crrev.com/e28eab4196fd3d2da875a39f89c3e83852ccd0af/third_party/WebKit/Source/core/inspector/browser_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d2e41de976b5fc40bedb9165ef243b3a7254ac commit e7d2e41de976b5fc40bedb9165ef243b3a7254ac Author: pfeldman <pfeldman@chromium.org> Date: Fri Sep 23 16:41:51 2016 DevTools: untangle device discovery request from the devtools android bridge. BUG= 627517 TBR=(api change) Review-Url: https://codereview.chromium.org/2361613002 Cr-Commit-Position: refs/heads/master@{#420633} [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/android_webview/browser/aw_devtools_manager_delegate.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/android_webview/browser/aw_devtools_manager_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/android/devtools_manager_delegate_android.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/android/devtools_manager_delegate_android.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/device/devtools_android_bridge.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/devtools_targets_ui.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/devtools_ui_bindings.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/devtools_window.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/devtools/devtools_window.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chrome/browser/ui/webui/inspect_ui.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chromecast/browser/devtools/cast_devtools_delegate.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/chromecast/browser/devtools/cast_devtools_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/forwarding_agent_host.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/forwarding_agent_host.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/browser/devtools/service_worker_devtools_manager.cc [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/public/browser/devtools_external_agent_proxy_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/content/shell/browser/shell_devtools_manager_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/headless/lib/browser/headless_devtools_manager_delegate.h [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js [modify] https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac/third_party/WebKit/Source/devtools/front_end/externs.js
Comment 1 by dgozman@chromium.org
, Aug 19 2016Owner: pfeldman@chromium.org