New issue
Advanced search Search tips

Issue 627511 link

Starred by 3 users
Status: Untriaged
Owner: ----
Cc:
alogvi...@yandex-team.ru
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Rewrite ScreenWakeLockTest into a LayoutTest

Project Member Reported by mcasas@chromium.org, Jul 12 2016 
ScreenWakeLockTest lives in WebKit/Source/web/tests and 
tests WakeLockService functionality. It should be 
transformed into a LayoutTest (or even into a Test file
in Source/modules/), but couldn't be done because it 
needs test infra located in web/, namely a 
FrameTestHelpers:WebViewHelper [2].


See
./out/gn/webkit_unit_tests  --gtest_filter=*ScreenWakeLockTest.*)



[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp?q=ScreenWakeLockTest.cpp&sq=package:chromium&dr
[2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp?q=ScreenWakeLockTest.cpp+m_webViewHelper&sq=package:chromium&l=160&dr=CSs

Comment 1 Deleted

Comment 2 by mcasas@chromium.org, Jul 22 2016 

Hmm what happened to Comment 1 ? I see it as "Deleted".
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 24 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment