New issue
Advanced search Search tips

Issue 627510 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 624590



Sign in to add a comment

Move components/webusb to chrome/browser

Project Member Reported by jam@chromium.org, Jul 12 2016

Issue description

It's only used by chrome/browser.
 

Comment 1 by juncai@chromium.org, Jul 12 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1da12030f6c17ef7d05218d0e812d4bd0c575c75

commit 1da12030f6c17ef7d05218d0e812d4bd0c575c75
Author: juncai <juncai@chromium.org>
Date: Fri Jul 15 19:10:12 2016

Move //components/webusb/ to //chrome/browser/

Since webusb is only used by //chrome/browser, this
CL moved the directory from //components to //chrome/browser.

The context is: https://bugs.chromium.org/p/chromium/issues/detail?id=624590

Since there is already a directory: //chrome/browser/usb, source files from
webusb directory is moved there. And it also changes webusb to web_usb to
be consistent with the filenames at //chrome/browser/usb.

BUG= 627510 

Review-Url: https://codereview.chromium.org/2146663002
Cr-Commit-Position: refs/heads/master@{#405808}

[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/BUILD.gn
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/chrome_browser_main.h
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/chrome/browser/chrome_webusb_browser_client.h
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/chrome/browser/chrome_webusb_browser_client_unittest.cc
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/usb/OWNERS
[rename] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/usb/web_usb_detector.cc
[rename] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/usb/web_usb_detector.h
[add] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/browser/usb/web_usb_detector_unittest.cc
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/chrome_browser.gypi
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/components/BUILD.gn
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/components/OWNERS
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/components/components.gyp
[modify] https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75/components/components_tests.gyp
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb.gypi
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/BUILD.gn
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/DEPS
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/OWNERS
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/webusb_browser_client.h
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/webusb_detector.cc
[delete] https://crrev.com/7fc01f2b3c636f54eb2a56ed0929fa142a0046ab/components/webusb/webusb_detector_unittest.cc

Comment 3 by juncai@chromium.org, Jul 19 2016

Status: Fixed (was: Started)

Sign in to add a comment