New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627506 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

touch_firmware_test doesn't support EV_MSC events on ChromeOS

Reported by charliemooney@chromium.org, Jul 12 2016

Issue description

It looks like EV_MSC events crash the ChromeOS remote touch device class.  It shouldn't ever crash even with unexpected events like this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/9f9ae32753ef011cfbe8bc31272ae658c5c6bacb

commit 9f9ae32753ef011cfbe8bc31272ae658c5c6bacb
Author: Charlie Mooney <charliemooney@chromium.org>
Date: Tue Jul 12 16:14:39 2016

Support EV_MSC event types for ChromeOS

A vendor reported the remote chromeos support crashing when EV_MSC
events were emitted by their touch device.  This seems to be due to
evtest reporting those events as hexidecimal values instead of base-10.
According to evtest's source there are only 2 events that it does this
for, so this CL adds in a check for those events in an attempt to parse
them correctly.

BUG= chromium:627506 
TEST=manually tested, then verified by the vendor

Change-Id: I268abe40e744c9dace0ded9082abbf1a52913f4c
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/359945
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[modify] https://crrev.com/9f9ae32753ef011cfbe8bc31272ae658c5c6bacb/remote/remote_in_system.py

Status: Fixed (was: Started)
Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment