Improve error message during first time sync setup |
|||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Clear the snippets using snippets-internals (2) Switch to an NTP (3) Restart Chrome Other config: sync enabled, happens for both host restrict being on or off. What is the expected output? - I would expect the snippets to be loaded soon after the NTP opens (<1s). - Maybe seeing some form of a spinner in the meantime would help. What do you see instead? - For ~10s, I see the card "Turn on history sync to get snippets". - Afterwards it is replaced by "Nothing to read" card for a very very short moment of time. (hard to notice) - Finally, it is replaced by the snippets.
,
Jul 14 2016
,
Jul 15 2016
The 10s delay sounds suspiciously like the Sync startup delay. I guess we somehow end up showing the "history sync disabled" card while we don't know yet what the status is?
,
Jul 15 2016
I think so too. We already have a bug about showing a spinner during this uncertainty period: issue 624338 I'll leave this one open to figure out why it takes so long and why we throw away the cards instead of leaving them there. It looks like a more up to date version of issue 623923 , that I'll mark as dupe.
,
Jul 15 2016
Issue 623923 has been merged into this issue.
,
Jul 15 2016
,
Jul 19 2016
,
Jul 20 2016
Actually, issue 626831 is the one about fixing the cards being thrown away, and the spinner from issue 624338 should fix the user visible issue. One aspect left on this bug is about the dependency on history sync. nepper@, I think you were looking into what we would do about the history sync dependency for serving suggestions, and how we surface that requirement to users. Any update on that?
,
Jul 20 2016
,
Jul 22 2016
Ok, so we don't need clear cards when history sync is disabled now, great. I will remove all that stuff from the client then.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c09dbeacff156f8712fcb69bd65188d11a711096 commit c09dbeacff156f8712fcb69bd65188d11a711096 Author: dgn <dgn@chromium.org> Date: Fri Jul 29 16:16:02 2016 [NTP Client] Remove SnippetService's dependency on Sync The SnippetService doesn't care about the sync state anymore so we can get rid of that dependency. BUG= 627488 TBR=noyau@chromium.org Review-Url: https://codereview.chromium.org/2191343002 Cr-Commit-Position: refs/heads/master@{#408650} [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/content_suggestions_category_status.h [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_status_service.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_status_service.h [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets/ntp_snippets_status_service_unittest.cc [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/components/ntp_snippets_strings.grdp [modify] https://crrev.com/c09dbeacff156f8712fcb69bd65188d11a711096/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc
,
Aug 1 2016
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bfd38b0fbfd42e7224b4b07430b781119036387 commit 0bfd38b0fbfd42e7224b4b07430b781119036387 Author: dgn <dgn@chromium.org> Date: Mon Aug 01 18:27:19 2016 [NTP Client] Fix SnippetsService's status reporting During the initial phases of the snippets service lifetime, it currently reports frequent state changes and does not use AVAILABLE_LOADING at all to notify its observers that it is currently fetching. This CL aims at fixing that to allow showing more useful information to the user. BUG= 627488 Review-Url: https://codereview.chromium.org/2190353002 Cr-Commit-Position: refs/heads/master@{#409002} [modify] https://crrev.com/0bfd38b0fbfd42e7224b4b07430b781119036387/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/0bfd38b0fbfd42e7224b4b07430b781119036387/components/ntp_snippets/ntp_snippets_service.h
,
Aug 2 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jkrcal@chromium.org
, Jul 12 2016Labels: -Pri-3 zine-articles-v1 OS-Android Pri-2