New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627483 link

Starred by 5 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Aug 2017
Cc:
█ kmadhusu@chromium.org
█ sfiera@chromium.org
█ jered@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 627747



Sign in to add a comment

Cleanup unused search/instant field trials

Project Member Reported by treib@chromium.org, Jul 12 2016 
chrome/browser/search/search.h/cc contain a number of field trials and corresponding helper functions, most of which seem to be unused these days (e.g. google_local_ntp, prefetch_results_srp, prerender_instant_url_on_omnibox_focus). We should clean up all that are either fully launched or abandoned, and remove all the plumbing.

Comment 1 by treib@chromium.org, Jul 12 2016

Cc: jered@chromium.org kmadhusu@chromium.org

Comment 2 by treib@chromium.org, Jul 12 2016

Components: UI>Browser>Instant>Extended

Comment 3 by treib@chromium.org, Jul 13 2016

Blocking: 627747

Comment 5 by treib@chromium.org, Jul 13 2016

Components: UI>Browser>Instant

Comment 6 by treib@chromium.org, Jul 13 2016 

IsQueryExtractionEnabled / query_extraction also seems to be dead.

Comment 8 by fi...@chromium.org, Jul 29 2016

Labels: zine-ntp-pe zine-triaged
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4fec3722b90b214511eb24745fa172c916f5902

commit c4fec3722b90b214511eb24745fa172c916f5902
Author: treib <treib@chromium.org>
Date: Fri Aug 12 09:53:28 2016

Remove search::IsQueryExtractionEnabled

BUG= 627747 , 627483 

Review-Url: https://codereview.chromium.org/2211983002
Cr-Commit-Position: refs/heads/master@{#411587}

[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/search/instant_unittest_base.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/search/instant_unittest_base.h
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/search/search.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/search/search.h
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/search/search_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/browser_instant_controller_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/toolbar/toolbar_model_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/omnibox/browser/verbatim_match.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search.h
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search_android_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search_switches.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search_switches.h
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/components/search/search_unittest.cc
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/ios/chrome/browser/BUILD.gn
[delete] https://crrev.com/ad430d0e3ed88bc0734c65e2861cd7a9e4864cce/ios/chrome/browser/search/search_util.h
[delete] https://crrev.com/ad430d0e3ed88bc0734c65e2861cd7a9e4864cce/ios/chrome/browser/search/search_util.mm
[modify] https://crrev.com/c4fec3722b90b214511eb24745fa172c916f5902/ios/chrome/ios_chrome.gyp
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e89046c82efaf8513328fb7cfae0bb7f3a813f9

commit 3e89046c82efaf8513328fb7cfae0bb7f3a813f9
Author: treib <treib@chromium.org>
Date: Tue Aug 16 09:09:05 2016

Remove search::ShouldUseAltInstantURL and ShouldUseSearchPathForInstant
Based on unused/abandoned field trials.

BUG= 627483 

Review-Url: https://codereview.chromium.org/2204363003
Cr-Commit-Position: refs/heads/master@{#412197}

[modify] https://crrev.com/3e89046c82efaf8513328fb7cfae0bb7f3a813f9/chrome/browser/search/search.cc
[modify] https://crrev.com/3e89046c82efaf8513328fb7cfae0bb7f3a813f9/chrome/browser/search/search.h
[modify] https://crrev.com/3e89046c82efaf8513328fb7cfae0bb7f3a813f9/chrome/browser/search/search_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/683745f53c0f2709e22c6305d97bf72fa5dc16ab

commit 683745f53c0f2709e22c6305d97bf72fa5dc16ab
Author: treib <treib@chromium.org>
Date: Tue Nov 29 15:31:18 2016

Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials

This removes the prefetch_results and reuse_instant_search_base_page parameters.

BUG= 627483 

Review-Url: https://codereview.chromium.org/2526753002
Cr-Commit-Position: refs/heads/master@{#434997}

[modify] https://crrev.com/683745f53c0f2709e22c6305d97bf72fa5dc16ab/components/search/search.cc
[modify] https://crrev.com/683745f53c0f2709e22c6305d97bf72fa5dc16ab/components/search/search.h

Comment 15 by treib@chromium.org, Jan 16 2017 

Progress report: Only the main "InstantExtended" aka "EmbeddedSearch" field trial still exists.

Comment 16 by treib@chromium.org, Aug 18 2017 

 Issue 333403  has been merged into this issue.
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b110412ea1831e57f0e6046b60fc556229c1399c

commit b110412ea1831e57f0e6046b60fc556229c1399c
Author: Marc Treib <treib@chromium.org>
Date: Mon Aug 21 09:57:08 2017

Cleanup: Remove InstantExtended/EmbeddedSearch field trial

and all the associated param parsing logic.
These haven't been used in years, and most of instant has been unlaunched.

Bug:  627483 
Change-Id: Ib7d892d1e0f3df8fbc75c9aea5d8bf742c6416c8
Reviewed-on: https://chromium-review.googlesource.com/620568
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495897}
[modify] https://crrev.com/b110412ea1831e57f0e6046b60fc556229c1399c/components/search/search.cc
[modify] https://crrev.com/b110412ea1831e57f0e6046b60fc556229c1399c/components/search/search.h
[modify] https://crrev.com/b110412ea1831e57f0e6046b60fc556229c1399c/components/search/search_android_unittest.cc
[modify] https://crrev.com/b110412ea1831e57f0e6046b60fc556229c1399c/components/search/search_unittest.cc

Comment 18 by treib@chromium.org, Aug 21 2017

Status: Fixed (was: Started)
►

Sign in to add a comment