features: The new settings doen't support Chinese quite well. Lot's contents are shown in English. bugs: It's not actually a bug.
@dbeam, when I change my Chromebook's language to French all of Settings is still in English. I've seen a few other reports about displaying in English -- is this a recent regression?
Issue 626896 has been merged into this issue.
tbuckley@: we're not translating settings strings yet. we should start.
Ah, that'd explain it. Keeping this as a dev-blocker in that case.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f0b8d8c55b720e17d35b197a8c6109a549a42bd commit 4f0b8d8c55b720e17d35b197a8c6109a549a42bd Author: dbeam <dbeam@chromium.org> Date: Fri Jul 15 22:38:26 2016 Start translating Material Design Settings again R=thestig@chromium.org BUG= 627474 Review-Url: https://codereview.chromium.org/2153703002 Cr-Commit-Position: refs/heads/master@{#405884} [modify] https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd/chrome/app/settings_chromium_strings.grd [modify] https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd/chrome/app/settings_google_chrome_strings.grd [modify] https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd/chrome/app/settings_strings.grd [modify] https://crrev.com/4f0b8d8c55b720e17d35b197a8c6109a549a42bd/tools/gritsettings/translation_expectations.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b037105da0249c217bb9cc3711e234a83344bed commit 6b037105da0249c217bb9cc3711e234a83344bed Author: dbeam <dbeam@chromium.org> Date: Wed Jul 20 20:22:14 2016 MD Settings: re-enable settings translations ONCE AND FOR ALL R=thestig@chromium.org BUG=629145, 627474 TBR=dpranke@chromium.org # for tools/OWNERS Review-Url: https://codereview.chromium.org/2163543004 Cr-Commit-Position: refs/heads/master@{#406654} [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/BUILD.gn [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/app/BUILD.gn [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/app/chromium_strings.grd [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/app/generated_resources.grd [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/app/google_chrome_strings.grd [delete] https://crrev.com/e64f73149ae4f997113777bc9cf3de8f5ab00e56/chrome/app/settings_chromium_strings.grd [delete] https://crrev.com/e64f73149ae4f997113777bc9cf3de8f5ab00e56/chrome/app/settings_google_chrome_strings.grd [delete] https://crrev.com/e64f73149ae4f997113777bc9cf3de8f5ab00e56/chrome/app/settings_strings.grd [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/metrics/variations/BUILD.gn [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/ui/webui/settings/certificates_handler.cc [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/ui/webui/settings/downloads_handler.cc [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/ui/webui/settings/people_handler.cc [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/chrome_repack_locales.gni [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/chrome_repack_resources.gypi [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/chrome/chrome_resources.gyp [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/tools/gritsettings/resource_ids [modify] https://crrev.com/6b037105da0249c217bb9cc3711e234a83344bed/tools/resources/list_resources_removed_by_repack.py
i thiiiink this is fixed now we'll re-open if translations don't start flowing in soon
Issue 649736 has been merged into this issue.
Comment 1 by tbuck...@chromium.org
, Jul 13 2016Labels: -Pri-2 Hotlist-MD-Settings-General Pri-1
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)