BackgroundWith1PxBorder doesn't work at fractional scale factors |
||||||||||
Issue descriptionsee omnibox outline in screenshot for example (1.5x scale)
,
Jul 12 2016
Fairly simple patch is here: https://codereview.chromium.org/2145713002/ pkasting@ would be the best reviewer but he's ooo. Do we care about trying to fix this in m53? If not, we can wait for Peter's return. If so, I'll try to find some other reviewer.
,
Jul 13 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb39becd04cdefd6aac776b659358458aa7ace23 commit eb39becd04cdefd6aac776b659358458aa7ace23 Author: estade <estade@chromium.org> Date: Tue Jul 19 20:33:55 2016 Adjust BackgroundWith1PxBorder to better handle fractional scale factors This fixes blurriness in the omnibox border on surface tablets. BUG= 627469 Review-Url: https://codereview.chromium.org/2145713002 Cr-Commit-Position: refs/heads/master@{#406371} [modify] https://crrev.com/eb39becd04cdefd6aac776b659358458aa7ace23/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc
,
Jul 21 2016
,
Jul 21 2016
this is a pretty small and safe fix, so I think it's worth merging to m53.
,
Jul 21 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0af855b7d79ce3de072a9a2f74dd80ec02ffae64 commit 0af855b7d79ce3de072a9a2f74dd80ec02ffae64 Author: Evan Stade <estade@chromium.org> Date: Thu Jul 21 17:31:20 2016 Adjust BackgroundWith1PxBorder to better handle fractional scale factors This fixes blurriness in the omnibox border on surface tablets. BUG= 627469 Review-Url: https://codereview.chromium.org/2145713002 Cr-Commit-Position: refs/heads/master@{#406371} (cherry picked from commit eb39becd04cdefd6aac776b659358458aa7ace23) Review URL: https://codereview.chromium.org/2172713002 . Cr-Commit-Position: refs/branch-heads/2785@{#265} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/0af855b7d79ce3de072a9a2f74dd80ec02ffae64/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc
,
Jul 22 2016
,
Jul 26 2016
Verified the butter bar on Chrome 53.0.2785.30 and it looks sharp, please find the attached screenshot. Note : Verified this on high dpi laptop with scale factor set to 150%.
,
Jul 26 2016
this bug is actually about the location bar outline, not the infobar.
,
Jul 27 2016
Tried to verify the fix for omnibox border on Window-10 with chrome versions(54.0.2809.0 - with Fix), (53.0.2785.21 - without Fix) and (53.0.2785.30 - Fix merged) at device scale factor of set to 250%. Attached is the screenshot of the same.
,
Jul 27 2016
great, looks good |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bsep@chromium.org
, Jul 12 2016