New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627451 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Autoplayed video does not pause when unmute on some page

Project Member Reported by zqzh...@chromium.org, Jul 12 2016

Issue description

The second video does pause after 2 seconds on
https://mounirlamouri.github.io/sandbox/autoplay/autoplay-muted.html

but doesn't pause on
https://xxyzzzq.github.io/sandbox/autoplay/autoplay-muted.html

The difference between the two pages is that the second page adds spacing above the videos.
 
It looks like an visibility issue.

It happens when navigating to the second page, waiting for autoplay start, and scrolling down. Seems like the ElementVisibilityObserver is not cancelled when unmuting.
Labels: -M-54 M-53
Status: Assigned (was: Available)
Nice catch Zhiqiang! We look into this. 
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Assigned)
Automatic reset to Available Blink>Media bugs with no owner and Status set to Assigned.
Labels: Needs-BlinkMediaTriage
Labels: -Pri-2 -M-54 -MovedFrom-53 -Needs-BlinkMediaTriage M-53 Pri-1
Owner: mlamouri@chromium.org
Status: Assigned (was: Available)
Taking this.
Status: Started (was: Assigned)
https://codereview.chromium.org/2250393002
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c578967369c610605ef62747d0b33f986cab0e23

commit c578967369c610605ef62747d0b33f986cab0e23
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Aug 17 13:33:54 2016

Cancel autoplay muted when visible if the video gets unmuted before being visible.

Otherwise, we end up autoplaying unmuted.

BUG= 627451 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2250393002
Cr-Commit-Position: refs/heads/master@{#412512}

[add] https://crrev.com/c578967369c610605ef62747d0b33f986cab0e23/third_party/WebKit/LayoutTests/media/autoplay-unmute-offscreen.html
[modify] https://crrev.com/c578967369c610605ef62747d0b33f986cab0e23/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Labels: Merge-Request-53
Given that the fix is fairly small, asking for m53 merge.

Comment 10 by dimu@chromium.org, Aug 17 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e

commit f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Aug 17 13:58:08 2016

Cancel autoplay muted when visible if the video gets unmuted before being visible.

Otherwise, we end up autoplaying unmuted.

BUG= 627451 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2250393002
Cr-Commit-Position: refs/heads/master@{#412512}
(cherry picked from commit c578967369c610605ef62747d0b33f986cab0e23)

Review URL: https://codereview.chromium.org/2253683004 .

Cr-Commit-Position: refs/branch-heads/2785@{#638}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[add] https://crrev.com/f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e/third_party/WebKit/LayoutTests/media/autoplay-unmute-offscreen.html
[modify] https://crrev.com/f2b3f2f1d6f517ba7fe244c7f7ac385a47b5246e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Status: Fixed (was: Started)

Sign in to add a comment