New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627447 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in ProfileChooserView::ButtonPressed

Project Member Reported by ClusterFuzz, Jul 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5229612129058816

Fuzzer: mbarbella_webgl
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  ProfileChooserView::ButtonPressed
  views::CustomButton::OnKeyPressed
  views::View::OnKeyEvent
  
Recommended Security Severity: Low

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=403906:404155

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96g_CgWtGybHBSdMYdFYnF4iDPCP0RTMUdtv9kAeBBxrEL0nvBROVx_bxXLeaUgZi_VS9yXbYAKaRYBkmCFyGw_DiQs3xXAmcOCGtuXwSIXx8kcSYGR9I171JHeI_ixsEDksSJcrPuq1vgzz43Eo3nqlWi0b2dE_MO5QliH6zKRhsgN8mk?testcase_id=5229612129058816


Additional requirements: Requires Gestures

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Jul 12 2016

Cc: janeliulwq@google.com
Components: UI>Browser>WebUI
Labels: Pri-2
Owner: rogerta@chromium.org
rogerta@, I wanted to assign this to your intern janeliulwq@, but the tracker doesn't let me to do this: "Issue owner must be a project member".

janeliulwq@, could you please take a look or suggest another owner?

You've recently changed some code related to this:

https://chromium.googlesource.com/chromium/src/+/478d83e5b642df214eea6a01d8a3a46b6b44cf1c
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2016

Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4804353b3d499e8000d31b6525e1f93aa48810

commit fd4804353b3d499e8000d31b6525e1f93aa48810
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 13 04:50:22 2016

Addressed use-of-uninitialized-value bug for manage_accounts_button_ on L1044

Tested with result "No crash found".

BUG= 627447 

Review-Url: https://codereview.chromium.org/2142053002
Cr-Commit-Position: refs/heads/master@{#405028}

[modify] https://crrev.com/fd4804353b3d499e8000d31b6525e1f93aa48810/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Thanks for catching this, this crash was indeed caused by my previous CL. 
The CL above should address this bug.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4804353b3d499e8000d31b6525e1f93aa48810

commit fd4804353b3d499e8000d31b6525e1f93aa48810
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 13 04:50:22 2016

Addressed use-of-uninitialized-value bug for manage_accounts_button_ on L1044

Tested with result "No crash found".

BUG= 627447 

Review-Url: https://codereview.chromium.org/2142053002
Cr-Commit-Position: refs/heads/master@{#405028}

[modify] https://crrev.com/fd4804353b3d499e8000d31b6525e1f93aa48810/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Project Member

Comment 6 by ClusterFuzz, Jul 14 2016

ClusterFuzz has detected this issue as fixed in range 404947:405052.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5229612129058816

Fuzzer: mbarbella_webgl
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  ProfileChooserView::ButtonPressed
  views::CustomButton::OnKeyPressed
  views::View::OnKeyEvent
  
Recommended Security Severity: Low

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=403906:404155
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=404947:405052

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96g_CgWtGybHBSdMYdFYnF4iDPCP0RTMUdtv9kAeBBxrEL0nvBROVx_bxXLeaUgZi_VS9yXbYAKaRYBkmCFyGw_DiQs3xXAmcOCGtuXwSIXx8kcSYGR9I171JHeI_ixsEDksSJcrPuq1vgzz43Eo3nqlWi0b2dE_MO5QliH6zKRhsgN8mk?testcase_id=5229612129058816


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 14 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 14 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 20 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment