New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627417 link

Starred by 3 users
Status: Verified
Owner:
cwallez@chromium.org
Closed: Jul 2016
Cc:
ynovikov@chromium.org
█ kbr@chromium.org
zmo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

WebglConformance_conformance_glsl_bugs_global_invariant_does_not_leak_across_shaders failing on Intel Mesa

Project Member Reported by cwallez@chromium.org, Jul 12 2016 
This was found after adding the test in #625363 The shaders failing compilation is:

--original-shader-- 

#pragma STDGL invariant(all) 

void main() 
{ 
gl_Position = vec4(1.0, 0.0, 0.0, 1.0); 
} 

--translated-shader-- 
#version 120 
#pragma STDGL invariant(all) 
#extension GL_ARB_gpu_shader5 : enable 
void main(){ 
(gl_Position = vec4(0.0, 0.0, 0.0, 0.0)); 
(gl_Position = vec4(1.0, 0.0, 0.0, 1.0)); 
}

The reason this fails is a Mesa driver bug in interpreting this blurb from the GLSL spec: "the extension directives must occur before any non-preprocessor tokens.".

The behavior has been fixed in Mesa 12.0.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b00dcee451c41e224d962cd9e03bf844c542464a

commit b00dcee451c41e224d962cd9e03bf844c542464a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Jul 11 21:42:58 2016

TranslatorGLSL/ESSL: Output #pragma before #extension

The Intel Mesa driver considers the #pragma directive to be a
non-preprocessor token which makes shaders fail compilation.

The relevant blurb from the spec is: "the extension directives
must occur before any non-preprocessor tokens"

BUG= 627417 

Change-Id: Ic22cff49a9f9c1fe5d140302581ca7b36688732c
Reviewed-on: https://chromium-review.googlesource.com/359621
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/b00dcee451c41e224d962cd9e03bf844c542464a/src/tests/gl_tests/GLSLTest.cpp
[modify] https://crrev.com/b00dcee451c41e224d962cd9e03bf844c542464a/src/compiler/translator/TranslatorESSL.cpp
[modify] https://crrev.com/b00dcee451c41e224d962cd9e03bf844c542464a/src/compiler/translator/TranslatorGLSL.cpp

Comment 2 by cwallez@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd38fb65da3ae6cacf0aab32971b92f9b4697031

commit cd38fb65da3ae6cacf0aab32971b92f9b4697031
Author: cwallez <cwallez@chromium.org>
Date: Wed Jul 13 15:11:49 2016

Roll ANGLE 9585a78..8495498

https://chromium.googlesource.com/angle/angle.git/+log/9585a78..8495498

BUG= 621031 , 627417 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2148803002
Cr-Commit-Position: refs/heads/master@{#405153}

[modify] https://crrev.com/cd38fb65da3ae6cacf0aab32971b92f9b4697031/DEPS
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd38fb65da3ae6cacf0aab32971b92f9b4697031

commit cd38fb65da3ae6cacf0aab32971b92f9b4697031
Author: cwallez <cwallez@chromium.org>
Date: Wed Jul 13 15:11:49 2016

Roll ANGLE 9585a78..8495498

https://chromium.googlesource.com/angle/angle.git/+log/9585a78..8495498

BUG= 621031 , 627417 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2148803002
Cr-Commit-Position: refs/heads/master@{#405153}

[modify] https://crrev.com/cd38fb65da3ae6cacf0aab32971b92f9b4697031/DEPS
►

Sign in to add a comment