New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in MaskSuperBlitter::blitH

Project Member Reported by ClusterFuzz, Jul 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5913512723611648

Fuzzer: afl_skia_path_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f56b90a01c4
Crash State:
  MaskSuperBlitter::blitH
  walk_convex_edges
  sk_fill_path
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=402185:402404

Minimized Testcase (0.04 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97zUc8bnAhpZTyKUbBZ8TcWt1EMaBqZPVeW87D6E47z3CQK0s-jW1KReHCvcE1GorXAiOh-guLTtsbkW2AUWVbqVHcjJ4DtqxsBGgg5aiX2sA7nXYDSdShe-RxWZoJLaLmAnffzk9y4oQzlaBt_dBCxD-EA2A?testcase_id=5913512723611648

Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mmoroz@chromium.org, Jul 12 2016

Cc: mmoroz@chromium.org metzman@google.com kcc@chromium.org aizatsky@chromium.org
Components: Internals>Skia
Labels: -Stability-Libfuzzer Pri-2
Owner: caryclark@chromium.org
Cc: caryclark@google.com
Owner: mmoroz@chromium.org
I don't see the command line reproduction for this one either. Also, please use my google.com address when assigning bugs to me. Thanks
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 12 2016

Labels: -Pri-2 Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 12 2016

Status: Assigned (was: Available)
I apologize for appearing dense but each time I get one of these bugs I have to re-learn the steps to repro. I see that if I follow enough links I get generic information about 'Clusterfuzz Local Reproduction' and 'Reproducing ClusterFuzz bugs' but to say these instructions are obtuse is an understatement.

It would be great if, in addition to generating a bug report, the clusterfuzz test suite also generated an executable script, that, given an environment that has previously been setup to reproduce a clusterfuzz bug, repros this bug. Thanks for any assistance you can provide.

Comment 6 by mmoroz@chromium.org, Jul 12 2016

Cc: -caryclark@google.com
Owner: caryclark@google.com
Thanks for the feedback! Instructions are there:  https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md#Reproducing-AFL-ASan-bugs

How to simplify the reproduction - is a good thing to think about.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 13 2016

Labels: M-53
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 13 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 13 2016

Status: Assigned (was: Available)
Cc: caryclark@google.com
Owner: reed@google.com
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147aa480f8470165482f39f14a41bf82372096dd

commit 147aa480f8470165482f39f14a41bf82372096dd
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Jul 13 21:40:54 2016

Roll src/third_party/skia/ 9199a9fef..82945560e (15 commits).

https://chromium.googlesource.com/skia.git/+log/9199a9fef989..82945560e61f

$ git log 9199a9fef..82945560e --date=short --no-merges --format='%ad %ae %s'
2016-07-13 bungeman Disable embedded bitmap test on iOS.
2016-07-13 reed handle large conic weights
2016-07-13 senorblanco Fix vertex count estimate in GrTessellator.
2016-07-13 csmartdalton Add resource provider flag to avoid client-side buffers
2016-07-13 mtklein Turn back on nanobench on Debug trybots.
2016-07-13 robertphillips Retract PipelineBuilder from GrClip::apply
2016-07-13 brianosman Never allow dither for non-legacy (sRGB or F16) targets.
2016-07-13 mtklein Revert "Added the framework for having canvas/recorder/picture record depth_set's."
2016-07-13 csmartdalton Fix various issues with instanced rendering precision
2016-07-13 csmartdalton Replace switch statements in instanced vertex shaders
2016-07-13 csmartdalton Fix GL shader sources getting truncated by ADB log
2016-07-13 vjiaoblack Added the framework for having canvas/recorder/picture record depth_set's. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002
2016-07-13 mtklein SkRasterPipeline: simplify impl and remove need to rewire stages
2016-07-13 msarett Try blacklisting RAW images on Nexus 9
2016-07-13 mtklein Update SkOpts namespaces.

BUG= 627414 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2149723002
Cr-Commit-Position: refs/heads/master@{#405301}

[modify] https://crrev.com/147aa480f8470165482f39f14a41bf82372096dd/DEPS

Project Member

Comment 13 by ClusterFuzz, Jul 14 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6514671813394432

Fuzzer: afl_skia_path_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f3231aaa9b9
Crash State:
  MaskSuperBlitter::blitH
  walk_convex_edges
  sk_fill_path
  
Recommended Security Severity: Medium


Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97mbnhWRIsQq8xsjYLPrN3yFBO0s01Qe_0ZdsfV_xRUirvYQ72PGRGgn2Jbklp2VhIEA2QbsvjePtl8kpSwMMhXe2752CMg4GyBxDuN68uufO-Dd5-qC362x-8CJVjRKcGrKKHQTn-gaNgHbK09R0vvPHy3ow?testcase_id=6514671813394432


Filer: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
M53 beta launch is coming soon.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Monday (07/18/16). Thank you.
M53 beta launch is next week.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Friday (07/22/16). Thank you.
Project Member

Comment 16 by sheriffbot@chromium.org, Jul 21 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Head ReleaseBlock-Beta
I'm afraid sheriffbot's label changes were a hiccup - this is still a blocker for Friday's M53. 
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 22 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 20 by sheriffbot@chromium.org, Jul 22 2016

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Head ReleaseBlock-Beta
Project Member

Comment 22 by sheriffbot@chromium.org, Jul 23 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 24 by ClusterFuzz, Jul 26 2016

ClusterFuzz has detected this issue as fixed in range 405208:405387.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6514671813394432

Fuzzer: afl_skia_path_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f3231aaa9b9
Crash State:
  MaskSuperBlitter::blitH
  walk_convex_edges
  sk_fill_path
  
Recommended Security Severity: Medium

Fixed: https://cluster-fuzz.appspot.com/revisions?job=afl_chrome_asan&range=405208:405387

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97mbnhWRIsQq8xsjYLPrN3yFBO0s01Qe_0ZdsfV_xRUirvYQ72PGRGgn2Jbklp2VhIEA2QbsvjePtl8kpSwMMhXe2752CMg4GyBxDuN68uufO-Dd5-qC362x-8CJVjRKcGrKKHQTn-gaNgHbK09R0vvPHy3ow?testcase_id=6514671813394432


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 25 by sheriffbot@chromium.org, Jul 26 2016

reed: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by sheriffbot@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 27 by sheriffbot@chromium.org, Jul 27 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 29 by sheriffbot@chromium.org, Nov 2 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment