Issue metadata
Sign in to add a comment
|
Regression: Unwanted scrollbars are seen in sync confirmation overlay in Ubuntu 14.04 |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.14 dev OS: Ubuntu 14.04 Pre-condition: Make sure new gaia password-separated sign in flow is enabled from chrome://flags What steps will reproduce the problem? (1) Launch chrome >> Go to chrome://settings >> Click on sign in to chrome button so that separate sign in overlay appears (2) Sign in with valid credentials >> Now observe the overlay for confirmation of sync Expected: No such unwanted scrollbars should be seen in sync confirmation overlay Actual: Instead unwanted scrollbars are seen. NOTE: Issue is not seen in windows. This is a regression issue broken in M51. Good Build: 51.0.2700.0 dev Bad Build: 51.0.2701.0 dev Unable to sign in to chromium builds. Hence providing manual changelog. CR: https://chromium.googlesource.com/chromium/src/+log/51.0.2700.0..51.0.2701.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/1814513002 from changelog. @anthonyvd: Please confirm the issue.
,
Jul 12 2016
Able to reproduce this on 53.0.2785.14 on Linux Ubuntu 14.04 and works fine on Mac OS 10.11.5 and Windows-7 with the same chrome version.
,
Aug 1 2016
Issue 633282 has been merged into this issue.
,
Aug 1 2016
Anthony - are you looking into this?
,
Sep 28 2016
yep, this is still a pretty huge bummer
,
Sep 28 2016
Anthony, this is labeled as P1 and has been open for a while. Can you please take a look at this as soon as possible, or else lower the priority if you don't think this should be a P1?
,
Sep 29 2016
I can't repro this at all, so I'll lower it to a P2 since this doesn't break the feature. I'd be interested to know if there are repros on an OS other than Ubuntu.
,
Sep 29 2016
FWIW, I remember being able to repro this on Ubuntu a couple months ago. It sounds to me like it's an Ubuntu-specific issue.
,
Oct 5 2016
,
Oct 14 2016
,
Nov 3 2016
I cannot reproduce this anymore on ToT (see attached screenshots). ajha@: Can you still reproduce this on the latest canary or dev?
,
Nov 3 2016
(Or dbeam, or anyone else who was able to repro this)
,
Nov 8 2016
This issue is still reproducible in 56.0.2913.0 dev, Ubuntu 14.04 Attaching video of same.
,
Nov 8 2016
sc00335628@techmahindra.com: May I ask you to attach the video?
,
Nov 8 2016
Oops! Sorry for missing that..
,
Nov 8 2016
I managed to reproduce this if I change the default values of this modal window: * I edited the values in https://cs.corp.google.com/clankium/src/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc?rcl=0&l=29 * I set the following values: const int kModalDialogWidth = 300; const int kSyncConfirmationDialogHeight = 300; Then I get both scrollbars. This basically means that https://cs.corp.google.com/clankium/src/chrome/browser/ui/webui/signin/signin_utils.cc?rcl=0&l=76 does not set a big enough value to get rid of the scrollbars. Increasing the height with 15 extra pixels gets rid of the vertical scrollbar.
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b510d0aebff97037598a470ff8f10901cc6187b commit 0b510d0aebff97037598a470ff8f10901cc6187b Author: msarda <msarda@chromium.org> Date: Thu Nov 10 17:47:02 2016 Hide scrollbars for the body of the sign-in dialogs. This CL hides the scrollbars for the body in all sign-in WebUI dialogs as all sign-in dialogs are resized when the document is loaded. BUG= 627411 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2484263002 Cr-Commit-Position: refs/heads/master@{#431283} [modify] https://crrev.com/0b510d0aebff97037598a470ff8f10901cc6187b/chrome/browser/resources/signin/signin_shared_css.html
,
Nov 14 2016
,
Apr 6 2017
Mihai, this appears to be happening again (at least for me on my Ubuntu machine) in the latest 57 stable. Can you please look into this?
,
May 8 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2017
I'll take a look today. Unfortunately, it looks like the only possible option I can come up with is to increase a bit the dialog on linux as the default values seems to lead to the scrollbars being shown.
,
Jun 8 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
Keeping as assigned, this is a simple product excellence thing that we should really try to address.
,
Jul 10 2017
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
--Chrome Identity automated triaging-- This bug is Available and has gone one year without any activity. If another month passes without any activity, this bug will be closed out. Please provide an update with the latest status for this bug. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 10
,
Aug 2
,
Sep 3
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
Sign-in triager: Thomas, can you please take a look?
,
Sep 7
We introduced a new confirmation dialog with Unity, so this should be WAI. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Jul 12 20164.0 MB
4.0 MB View Download