[MD History]Unable to remove the selected URL on History page using keyboard shortcut.
Reported by
dchau...@etouch.net,
Jul 12 2016
|
|||||
Issue descriptionChrome Version: 54.0.2794.0 (Official Build)02e8e6a146a2a17dcd8950b783130d5937ce87dd-refs/heads/master@{#404734} 32/64-bit. OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS). Precondition: 1. Enable the 'Material Design history' flag from chrome://flags. 2. Navigates to some webpages such that history gets created on chrome://history page. What steps will reproduce the problem? 1. Launch chrome and navigates to chrome://history page. 2. check the checkbox of any URL, press 'Delete' key from keyboard and observe. Nothing happens on pressing the 'Delete' key from keyboard. Selected URL should get deleted on pressing the 'Delete' key from keyboard. This is a non-regression issue seen from M-50 series, as this is a new feature introduced from build # 50.0.2638.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/50.0.2637.0..50.0.2638.0?pretty=fuller&n=100 Suspecting: r372589 ? Kindly review the attached screen-cast for reference.
,
Jul 13 2016
Yup, we should add support for this keyboard shortcut.
,
Jul 13 2016
Yeah, I'll add a shortcut for this:-)
,
Jul 15 2016
Press 'Backspace' key will also delete selected history items in old history page. Are we adding this as well?
,
Jul 15 2016
Sure, I don't see why not.
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24cca661cb0b2afe2ca1b1fa960924b375d63256 commit 24cca661cb0b2afe2ca1b1fa960924b375d63256 Author: lshang <lshang@chromium.org> Date: Wed Jul 20 23:49:44 2016 MD History: Add shortcuts for 'Delete' and 'Backspace' to delete selected items Press 'Delete' or 'Backspace' key from keyboard will delete selected history items on MD History. BUG= 627408 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2159773003 Cr-Commit-Position: refs/heads/master@{#406715} [modify] https://crrev.com/24cca661cb0b2afe2ca1b1fa960924b375d63256/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/24cca661cb0b2afe2ca1b1fa960924b375d63256/chrome/browser/resources/md_history/history.html [modify] https://crrev.com/24cca661cb0b2afe2ca1b1fa960924b375d63256/chrome/test/data/webui/md_history/history_list_test.js
,
Jul 21 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msrchandra@chromium.org
, Jul 12 2016