Issue metadata
Sign in to add a comment
|
Consider using base::Clock in PersonalDataManager |
||||||||||||||||||||||
Issue descriptionMany tests in PersonalDataManagerTest.* are dependent on wall clock time, thus occasionally flake when the bots are overloaded: [ RUN ] PersonalDataManagerTest.MergeProfile_UsageStats personal_data_manager_unittest.cc(4477): error: Expected: (base::TimeDelta::FromMilliseconds(500)) > (base::Time::Now() - profile.use_date()), actual: 0.5s vs 0.56734s [ FAILED ] PersonalDataManagerTest.MergeProfile_UsageStats (905 ms) Ideally, PersonalDataManagerTest should take a base::Clock so time can be mocked out and the tests are fully deterministic in this regard. Practically, the 500 ms timeouts should be increased so there is a lower chance of a flake. Also see: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/50521
,
Jul 21 2016
I'm actually the right person to assign this to. I just have to finish a few things but I should work on that very soon. Thanks for reporting this!
,
Jul 24 2016
This is not related to Flakiness Pipeline or Flakiness Dashboard. Removing the label.
,
Jul 24 2016
This is not related to Flakiness Pipeline or Flakiness Dashboard. Removing the label.
,
Jul 24 2016
Re-adding the component until a decision in issue 630900 is made.
,
Jul 25 2016
As decided in issue 630900, please do not use Infra>Flakiness label for specific flaky test. This bug already has the right component assigned.
,
Jul 25 2016
,
Jan 27 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by engedy@chromium.org
, Jul 12 2016