New issue
Advanced search Search tips

Issue 627385 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

node.canParticipateInFlatTree() in FlatTreeTraversal.h

Project Member Reported by ClusterFuzz, Jul 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6562935031988224

Fuzzer: inferno_twister
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  node.canParticipateInFlatTree() in FlatTreeTraversal.h
  blink::FlatTreeTraversal::assertPrecondition
  blink::FlatTreeTraversal::parent
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=402485:402737

Minimized Testcase (0.12 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94BCy3leQmeVmPHGvocNP1nmzu1c4XsBD9xa_xAYrqrV3vPDHXXeMgXgpUS4O3uuE9yKI4HfJLsNky5okLAYPDN_Hf4ZMWyCNCnalKWv107HaEjevYEV6SpPx6dhDpOgya7KVJeQjFpz0VbaayMNi21_7Igng?testcase_id=6562935031988224
<script>
tCF18 = document.createElementNS("http://www.w3.org/1999/xhtml", "slot");
tCF18.setAttribute("dir", "auto");
</script>


Filer: kavvaru

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>NoResult Blink>Layout
Labels: Te-Logged M-53
Owner: szager@chromium.org
Status: Assigned (was: Available)
Findit failed to get the suspected CLs.

Regressed CL::
https://chromium.googlesource.com/chromium/src/+log/70770adcfe2262b6886e19ac445d7c791892d011..54d1f9df4118e208a39621d41d72dca8eb969af3?pretty=fuller

Possible suspect from the above CL
https://codereview.chromium.org/2105963002

szager@ Could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue.

Thanks,
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by e...@chromium.org, Jul 19 2016

Components: -Blink>Layout -Tools>Test>FindIt>NoResult Blink>Loader
Owner: ----
Status: Untriaged (was: Assigned)
Components: Blink>WebComponents Blink>DOM
Labels: -ClusterFuzz Clusterfuzz
eae@, was there a particular reason this was triaged to loading?

Adding some common Shadow DOM components for further triage. Hopefully repro is easy, looks like two lines of JS. I'm building an asan content_shell now to hopefully repro on TOT. Will update if it repros.
Nevermind it crashes even on TOT release build with DCHECKs always on :)
Owner: hayato@chromium.org
Status: Assigned (was: Untriaged)
hayato@, do you mind taking a look at this one? I'm unfamiliar with the slot element, and Shadow DOM in general.

FYI for future in case it stops being reproducible. This crashed content_shell with DCHECK_ALWAYS_ON, synced to #406848 by navigating to:

data:text/html;charset=utf-8,<script>tCF18 = document.createElementNS("http://www.w3.org/1999/xhtml", "slot"); tCF18.setAttribute("dir", "auto");
;</script>

Comment 7 by hayato@chromium.org, Jul 22 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c75de11273c24c2a26738c5298074dac079b1016

commit c75de11273c24c2a26738c5298074dac079b1016
Author: hayato <hayato@chromium.org>
Date: Fri Jul 22 09:12:36 2016

Fix a crash caused by changing dir attribute of a slot element

HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this)
unconditionally. Since Blink does not support "slots in a flat tree", we
should return early here for a slot element.

BUG= 627385 

Review-Url: https://codereview.chromium.org/2172133002
Cr-Commit-Position: refs/heads/master@{#407108}

[add] https://crrev.com/c75de11273c24c2a26738c5298074dac079b1016/third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html
[modify] https://crrev.com/c75de11273c24c2a26738c5298074dac079b1016/third_party/WebKit/Source/core/html/HTMLElement.cpp

Comment 9 by hayato@chromium.org, Jul 22 2016

Status: Fixed (was: Started)
Thank you for the prompt fix :)
Project Member

Comment 11 by ClusterFuzz, Jul 23 2016

ClusterFuzz has detected this issue as fixed in range 406809:407197.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6562935031988224

Fuzzer: inferno_twister
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  node.canParticipateInFlatTree() in FlatTreeTraversal.h
  blink::FlatTreeTraversal::assertPrecondition
  blink::FlatTreeTraversal::parent
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=402485:402737
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=406809:407197

Minimized Testcase (0.12 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94BCy3leQmeVmPHGvocNP1nmzu1c4XsBD9xa_xAYrqrV3vPDHXXeMgXgpUS4O3uuE9yKI4HfJLsNky5okLAYPDN_Hf4ZMWyCNCnalKWv107HaEjevYEV6SpPx6dhDpOgya7KVJeQjFpz0VbaayMNi21_7Igng?testcase_id=6562935031988224
<script>
tCF18 = document.createElementNS("http://www.w3.org/1999/xhtml", "slot");
tCF18.setAttribute("dir", "auto");
</script>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment