factory: Factory UI Startup failure on ToT test images. |
||||||||||||||||
Issue description
Version: ToT
OS: Chrome
What steps will reproduce the problem?
(1) Get a ToT (R54) test image
(2) Install a factory toolkit and make sure you've turned on presenter (ToT factory toolkit by default uses monolithic mode. Do --enable-device --enable-presenter when running installer)
(3) Make sure /usr/local/factory/init/run_goofy_{device,presenter} exist
(4) Reboot
What is the expected output?
Factory UI should start
What do you see instead?
A message saying
oaao...xxx is blocked (oaao... is the ID of our factory presenter extension)
Requests to the server have been blocked by an extension.
Try disabling your extensions.
ERR_BLOCKED_BY_CLIENT
,
Aug 10 2016
Some notes: Presenter app is affected by this CL: https://codereview.chromium.org/2108853002/ which restricted --load-and-launch-apps in non-developer mode. Rewrite presenter app to a "platform app" may solve this problem.
,
Aug 10 2016
or --load-app and then override starting link.
,
Aug 18 2016
monolithic mode is probably also having problems?
,
Aug 18 2016
Monolithic has a different root cause, not sure if both can be fixed using the same way.
,
Sep 8 2016
I'm going to raise this priority since we're seeing more and more projects (for example, http://crosbug.com/p/56394 ) having similar problems, and we do need some solution (or, at least make sure monolithic mode works). +pihsun - pihsun, can you also take a look at this?
,
Sep 11 2016
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2016
Goal: find a path that people can get working UI, that - reboot will bring up UI without problems (no need to click reload) - keyboard focus will be set properly (i.e., don't need to click on test area when running keyboard test) Current situation: - monolithic mode can't set keyboard focus correctly. we've also got report from youcheng@ that Gru may fail to load init pages and need few extra reloads. - presenter mode fail to load extension. Even if loaded, first page still needs reload. Please find a way (either presenter or monolithic) so we can achieve the goals. Even better if we can fix both. Or, if it's really too hard, I'm ok with the proposal of deprecating one.
,
Sep 12 2016
+earl If you prefer to kill one path (monolithic or presenter), please discuss with Earl to see if that will change his modular goofy.
,
Sep 12 2016
I've successfully rewrite the presenter app to kiosk mode, it works now. But the focus problem still exists, need more experiment about this...
,
Sep 12 2016
sounds great. can you upload the change of kiosk mode presenter app? then at least it won't break. BTW do you mean the focus problem now also occurs on presenter mode?
,
Sep 12 2016
previous we only have keyboard focus problem on monolithic mode - and running presenter mode + old test image (which still allows loading extension) didn't have focus problem...
,
Sep 13 2016
CL here: https://chromium-review.googlesource.com/#/c/384077 Yes, the focus problem now also occurs on presenter mode.
,
Sep 13 2016
Too bad. Let's fix one-by-one...
,
Sep 26 2016
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/7347e5e18ccf3bda61d6c2536ea11b6e03802b0b commit 7347e5e18ccf3bda61d6c2536ea11b6e03802b0b Author: Ting Shen <phoenixshen@google.com> Date: Thu Oct 20 08:19:05 2016 goofy: fix keyboard focus Add a redirect to make browser sets focus correctly. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 Change-Id: I07ff3ee59d60d2407c072af50d195760c9e13777 Reviewed-on: https://chromium-review.googlesource.com/401318 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [add] https://crrev.com/7347e5e18ccf3bda61d6c2536ea11b6e03802b0b/py/goofy/factory_test_extension/main.html [add] https://crrev.com/7347e5e18ccf3bda61d6c2536ea11b6e03802b0b/py/goofy/factory_test_extension/main.js [modify] https://crrev.com/7347e5e18ccf3bda61d6c2536ea11b6e03802b0b/init/goofy.d/monolithic/chrome_dev.conf
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ebf38947e716255502a8b3afb2f9534e38fbfb61 commit ebf38947e716255502a8b3afb2f9534e38fbfb61 Author: Ting Shen <phoenixshen@google.com> Date: Wed Oct 26 07:27:00 2016 goofy: focus fix on older version On old version of chrome, CL:401318 failed with net::ERR_ADDRESS_UNREACHABLE while loading main.js. Use meta refresh to avoid this problem. CQ-DEPEND=CL:401318 BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 on M49 Change-Id: I3ef271da263ebebe2b5474d8e0edebf001ba8484 Reviewed-on: https://chromium-review.googlesource.com/403748 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org> [modify] https://crrev.com/ebf38947e716255502a8b3afb2f9534e38fbfb61/py/goofy/factory_test_extension/main.html [delete] https://crrev.com/78e11046e9acf51f0bee6bf58aab0474c1dec5a9/py/goofy/factory_test_extension/main.js
,
Oct 27 2016
Seems like we've fixed monolithic mode. What about presenter mode?
,
Oct 27 2016
Maybe we can deprecate it now?
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ba1fd7036ac93b42cb0be942a8fc61f30751cf2a commit ba1fd7036ac93b42cb0be942a8fc61f30751cf2a Author: Ting Shen <phoenixshen@google.com> Date: Thu Oct 20 08:19:05 2016 goofy: fix keyboard focus Add a redirect to make browser sets focus correctly. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 Change-Id: I07ff3ee59d60d2407c072af50d195760c9e13777 Reviewed-on: https://chromium-review.googlesource.com/401318 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 7347e5e18ccf3bda61d6c2536ea11b6e03802b0b) Reviewed-on: https://chromium-review.googlesource.com/403711 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> [add] https://crrev.com/ba1fd7036ac93b42cb0be942a8fc61f30751cf2a/py/goofy/factory_test_extension/main.html [add] https://crrev.com/ba1fd7036ac93b42cb0be942a8fc61f30751cf2a/py/goofy/factory_test_extension/main.js [modify] https://crrev.com/ba1fd7036ac93b42cb0be942a8fc61f30751cf2a/init/goofy.d/monolithic/chrome_dev.conf
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9e4af78ff6af1b23f3f6d9f0697426c2f3d74baf commit 9e4af78ff6af1b23f3f6d9f0697426c2f3d74baf Author: Ting Shen <phoenixshen@google.com> Date: Wed Oct 26 07:27:00 2016 goofy: focus fix on older version On old version of chrome, CL:401318 failed with net::ERR_ADDRESS_UNREACHABLE while loading main.js. Use meta refresh to avoid this problem. CQ-DEPEND=CL:401318 BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 on M49 Change-Id: I3ef271da263ebebe2b5474d8e0edebf001ba8484 Reviewed-on: https://chromium-review.googlesource.com/403748 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org> (cherry picked from commit ebf38947e716255502a8b3afb2f9534e38fbfb61) Reviewed-on: https://chromium-review.googlesource.com/403715 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> [modify] https://crrev.com/9e4af78ff6af1b23f3f6d9f0697426c2f3d74baf/py/goofy/factory_test_extension/main.html [delete] https://crrev.com/9f6b72de3c37719ef42b920eb226302cd534e50b/py/goofy/factory_test_extension/main.js
,
Oct 27 2016
I'd like to get it fixed before deprecation, if possible and if that's not too hard. Do you think it's something very trivial, or will it need lots of rewrite / development?
,
Oct 27 2016
I think the redirection trick also works on presenter app. Just a small change.
,
Oct 27 2016
Then can you please make that happen and then we can close this issue :) (I'm concerned if people may see random issues that only works in presenter mode, so let's keep it working for one more generation) Thanks!
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/23d62b39e8720bd285d4ac5398b29125dd8a555d commit 23d62b39e8720bd285d4ac5398b29125dd8a555d Author: Ting Shen <phoenixshen@google.com> Date: Thu Oct 20 08:19:05 2016 goofy: fix keyboard focus Add a redirect to make browser sets focus correctly. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 Change-Id: I07ff3ee59d60d2407c072af50d195760c9e13777 Reviewed-on: https://chromium-review.googlesource.com/401318 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 7347e5e18ccf3bda61d6c2536ea11b6e03802b0b) Reviewed-on: https://chromium-review.googlesource.com/403710 Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Loop Wu <Loop_Wu@asus.com> Reviewed-by: Loop Wu <Loop_Wu@asus.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> [add] https://crrev.com/23d62b39e8720bd285d4ac5398b29125dd8a555d/py/goofy/factory_test_extension/main.html [add] https://crrev.com/23d62b39e8720bd285d4ac5398b29125dd8a555d/py/goofy/factory_test_extension/main.js [modify] https://crrev.com/23d62b39e8720bd285d4ac5398b29125dd8a555d/init/goofy.d/monolithic/chrome_dev.conf
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/d3e0b57c921d728860efaa8296f27cec90b6de38 commit d3e0b57c921d728860efaa8296f27cec90b6de38 Author: Ting Shen <phoenixshen@google.com> Date: Wed Oct 26 07:27:00 2016 goofy: focus fix on older version On old version of chrome, CL:401318 failed with net::ERR_ADDRESS_UNREACHABLE while loading main.js. Use meta refresh to avoid this problem. CQ-DEPEND=CL:401318 BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 on M49 Change-Id: I3ef271da263ebebe2b5474d8e0edebf001ba8484 Reviewed-on: https://chromium-review.googlesource.com/403748 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org> (cherry picked from commit ebf38947e716255502a8b3afb2f9534e38fbfb61) Reviewed-on: https://chromium-review.googlesource.com/404034 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Jiazi Yang <Tomato_Yang@asus.com> Tested-by: Jiazi Yang <Tomato_Yang@asus.com> [modify] https://crrev.com/d3e0b57c921d728860efaa8296f27cec90b6de38/py/goofy/factory_test_extension/main.html [delete] https://crrev.com/23d62b39e8720bd285d4ac5398b29125dd8a555d/py/goofy/factory_test_extension/main.js
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/e4e0c9b17537f5441a41780f0ddc96b283d2dacc commit e4e0c9b17537f5441a41780f0ddc96b283d2dacc Author: Ting Shen <phoenixshen@google.com> Date: Thu Oct 20 08:19:05 2016 goofy: fix keyboard focus Add a redirect to make browser sets focus correctly. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 Change-Id: I07ff3ee59d60d2407c072af50d195760c9e13777 Reviewed-on: https://chromium-review.googlesource.com/401318 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 7347e5e18ccf3bda61d6c2536ea11b6e03802b0b) Reviewed-on: https://chromium-review.googlesource.com/406808 Reviewed-by: Youcheng Syu <youcheng@google.com> Commit-Queue: Youcheng Syu <youcheng@google.com> Tested-by: Youcheng Syu <youcheng@google.com> [add] https://crrev.com/e4e0c9b17537f5441a41780f0ddc96b283d2dacc/py/goofy/factory_test_extension/main.html [add] https://crrev.com/e4e0c9b17537f5441a41780f0ddc96b283d2dacc/py/goofy/factory_test_extension/main.js [modify] https://crrev.com/e4e0c9b17537f5441a41780f0ddc96b283d2dacc/init/goofy.d/monolithic/chrome_dev.conf
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/d29153c7ec8a6de4240f91d171ca16839939e065 commit d29153c7ec8a6de4240f91d171ca16839939e065 Author: Ting Shen <phoenixshen@google.com> Date: Wed Oct 26 07:27:00 2016 goofy: focus fix on older version On old version of chrome, CL:401318 failed with net::ERR_ADDRESS_UNREACHABLE while loading main.js. Use meta refresh to avoid this problem. CQ-DEPEND=CL:401318 BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 on M49 Change-Id: I3ef271da263ebebe2b5474d8e0edebf001ba8484 Reviewed-on: https://chromium-review.googlesource.com/403748 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org> (cherry picked from commit ebf38947e716255502a8b3afb2f9534e38fbfb61) Reviewed-on: https://chromium-review.googlesource.com/406811 Reviewed-by: Youcheng Syu <youcheng@google.com> Commit-Queue: Youcheng Syu <youcheng@google.com> Tested-by: Youcheng Syu <youcheng@google.com> [modify] https://crrev.com/d29153c7ec8a6de4240f91d171ca16839939e065/py/goofy/factory_test_extension/main.html [delete] https://crrev.com/e4e0c9b17537f5441a41780f0ddc96b283d2dacc/py/goofy/factory_test_extension/main.js
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9014e755a6a23deb59608adac52a973158472878 commit 9014e755a6a23deb59608adac52a973158472878 Author: Ting Shen <phoenixshen@google.com> Date: Wed Nov 02 07:19:58 2016 presenter: fix init and focus problem 1. Load presenter app as an extension, this change solved the 'presenter app is blocked' error. 2. Fix focus problem by triggering a reload from factory_test_extension. The reload needs to be triggered from a different domain, factory test extension seems like a good place to do this. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0, verified on M49 & M55 Change-Id: If183e282a447d9aacf118eeae8565cc208a28330 Reviewed-on: https://chromium-review.googlesource.com/406787 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [add] https://crrev.com/9014e755a6a23deb59608adac52a973158472878/py/goofy/factory_test_extension/redirect-to-presenter.html [modify] https://crrev.com/9014e755a6a23deb59608adac52a973158472878/init/goofy.d/presenter/chrome_dev.conf
,
Nov 2 2016
,
Jan 21 2017
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a2c12d2a4fcf52245fb42b9c0031f1ca361bc280 commit a2c12d2a4fcf52245fb42b9c0031f1ca361bc280 Author: Ting Shen <phoenixshen@google.com> Date: Thu Oct 20 08:19:05 2016 goofy: fix keyboard focus Add a redirect to make browser sets focus correctly. BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 Change-Id: I07ff3ee59d60d2407c072af50d195760c9e13777 Reviewed-on: https://chromium-review.googlesource.com/401318 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> (cherry picked from commit 7347e5e18ccf3bda61d6c2536ea11b6e03802b0b) Reviewed-on: https://chromium-review.googlesource.com/431822 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> [add] https://crrev.com/a2c12d2a4fcf52245fb42b9c0031f1ca361bc280/py/goofy/factory_test_extension/main.html [add] https://crrev.com/a2c12d2a4fcf52245fb42b9c0031f1ca361bc280/py/goofy/factory_test_extension/main.js [modify] https://crrev.com/a2c12d2a4fcf52245fb42b9c0031f1ca361bc280/init/goofy.d/monolithic/chrome_dev.conf
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/fce3519afe21016a881af6a1b0dc76fde60ecc1b commit fce3519afe21016a881af6a1b0dc76fde60ecc1b Author: Ting Shen <phoenixshen@google.com> Date: Wed Oct 26 07:27:00 2016 goofy: focus fix on older version On old version of chrome, CL:401318 failed with net::ERR_ADDRESS_UNREACHABLE while loading main.js. Use meta refresh to avoid this problem. CQ-DEPEND=CL:401318 BUG= chromium:627372 TEST=start goofy and press ctrl-alt-0 on M49 Change-Id: I3ef271da263ebebe2b5474d8e0edebf001ba8484 Reviewed-on: https://chromium-review.googlesource.com/403748 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org> (cherry picked from commit ebf38947e716255502a8b3afb2f9534e38fbfb61) Reviewed-on: https://chromium-review.googlesource.com/431824 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/fce3519afe21016a881af6a1b0dc76fde60ecc1b/py/goofy/factory_test_extension/main.html [delete] https://crrev.com/a2c12d2a4fcf52245fb42b9c0031f1ca361bc280/py/goofy/factory_test_extension/main.js
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/60ae10e81381f2c55fc85b562ba4ccf06ec857e4 commit 60ae10e81381f2c55fc85b562ba4ccf06ec857e4 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 13 08:46:09 2017 jailbreak: Only do jailbreak for specified services. There are too many problems when we are trying to replace minijail0. To prevent breaking ToT, a solution is to only jailbreak known services we need (sslh). Also implemented '-i' for Upstart to track 'expect fork' correctly. BUG= chromium:627372 TEST=Deployed on SNAPPY and started factory UI. Change-Id: Ie3c6aa1c12daf96d101ef86752a4f3895490e814 Reviewed-on: https://chromium-review.googlesource.com/441550 Reviewed-by: Youcheng Syu <youcheng@google.com> Commit-Queue: Youcheng Syu <youcheng@google.com> Tested-by: Youcheng Syu <youcheng@google.com> [modify] https://crrev.com/60ae10e81381f2c55fc85b562ba4ccf06ec857e4/init/goofy.d/device/jailbreak/minijail0 [modify] https://crrev.com/60ae10e81381f2c55fc85b562ba4ccf06ec857e4/init/goofy.d/device/jailbreak.sh
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/4fc45aa8b6f883b558b105247d299a94c24b73c7 commit 4fc45aa8b6f883b558b105247d299a94c24b73c7 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Feb 13 13:04:30 2017 jailbreak: Only do jailbreak for specified services. There are too many problems when we are trying to replace minijail0. To prevent breaking ToT, a solution is to only jailbreak known services we need (sslh). Also implemented '-i' for Upstart to track 'expect fork' correctly. BUG= chromium:627372 TEST=Deployed on SNAPPY and started factory UI. Change-Id: Ie3c6aa1c12daf96d101ef86752a4f3895490e814 Reviewed-on: https://chromium-review.googlesource.com/441469 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/4fc45aa8b6f883b558b105247d299a94c24b73c7/init/goofy.d/device/jailbreak/minijail0 [modify] https://crrev.com/4fc45aa8b6f883b558b105247d299a94c24b73c7/init/goofy.d/device/jailbreak.sh
,
Mar 4 2017
,
Apr 17 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/5b84c5abee1ce3d6793ff020961a51dbb1d8b030 commit 5b84c5abee1ce3d6793ff020961a51dbb1d8b030 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Apr 27 09:14:41 2017 jailbreak: Only do jailbreak for specified services. There are too many problems when we are trying to replace minijail0. To prevent breaking ToT, a solution is to only jailbreak known services we need (sslh). Also implemented '-i' for Upstart to track 'expect fork' correctly. BUG= chromium:627372 TEST=Deployed on SNAPPY and started factory UI. Change-Id: Ie3c6aa1c12daf96d101ef86752a4f3895490e814 Reviewed-on: https://chromium-review.googlesource.com/441469 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> (cherry picked from commit 4fc45aa8b6f883b558b105247d299a94c24b73c7) Reviewed-on: https://chromium-review.googlesource.com/487853 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> [modify] https://crrev.com/5b84c5abee1ce3d6793ff020961a51dbb1d8b030/init/goofy.d/device/jailbreak/minijail0 [modify] https://crrev.com/5b84c5abee1ce3d6793ff020961a51dbb1d8b030/init/goofy.d/device/jailbreak.sh
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by hungte@chromium.org
, Jul 12 2016Status: Assigned (was: Untriaged)