Regression : Unable to delete folder using 'Delete' key from keyboard in chrome://bookmarks page.
Reported by
mni...@etouch.net,
Jul 12 2016
|
||||
Issue descriptionVersion: 54.0.2794.0 02e8e6a146a2a17dcd8950b783130d5937ce87dd-refs/heads/master@{#404734} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1) Launch chrome,navigate to chrome://bookmarks 2) Now click on 'Folders' and add two,three folders. 3) Now select any added folder and press 'Delete' key from keyboard,observe Actual : Unable to delete folder using 'Delete' key from keyboard Expected : Should be able to delete 'Folder' using 'Delete' key from keyboard This is a regression issue broken in 'M-54' and below is the manual regression and Narrow bisect info: Good build : 54.0.2788.0 Bad build : 54.0.2789.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/c0d77c92456d4cbf1116393862159a86426cb270..89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d?pretty=fuller&n=50 Suspecting : r403715 ? from Narrow bisect @dtapuska : Could you please help to reassign if your change is not the cause for this change.
,
Jul 12 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7185ed0ef16da5c97142491d4c6d07df5c4e250b commit 7185ed0ef16da5c97142491d4c6d07df5c4e250b Author: dtapuska <dtapuska@chromium.org> Date: Wed Jul 13 02:19:14 2016 Fix keyboard commands on bookmarks page. Appears I missed a set of hotkey commands on the bookmark page when removing keyIdentifier and supporting KeyboardEvent.key. I've verified U+007F is no longer used via a grep. Remove some dead code too. BUG= 627364 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2140853003 Cr-Commit-Position: refs/heads/master@{#404902} [modify] https://crrev.com/7185ed0ef16da5c97142491d4c6d07df5c4e250b/chrome/browser/resources/bookmark_manager/js/main.js
,
Jul 13 2016
,
Sep 27 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by msrchandra@chromium.org
, Jul 12 2016