New issue
Advanced search Search tips

Issue 627363 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

power_IdleSuspend failures.

Project Member Reported by tbroch@chromium.org, Jul 12 2016

Issue description

power_IdleSuspend failures.

1. 'timed out waiting for suspend' due to
[0711/210506:INFO:state_controller.cc(857)] Not performing idle action without OOBE completed
[0711/210506:INFO:state_controller.cc(872)] Ready to perform idle action (no-op) after 10s

2. 'bad power state written to /sys/power/state' due to lack of s0ix support ('freeze' instead of 'mem' to /sys/power/state)

Plenty of instances of both in latest wmatrix.

https://wmatrix.googleplex.com/matrix/unfiltered?suites=kernel_per-build_regression&tests=power_IdleSuspend&days_back=28



 

Comment 1 by tbroch@chromium.org, Jul 12 2016

Components: OS>Kernel>Power
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9ffca445edd9e7e2141a66be0b62d4c8ed76e225

commit 9ffca445edd9e7e2141a66be0b62d4c8ed76e225
Author: Todd Broch <tbroch@chromium.org>
Date: Tue Jul 12 06:57:24 2016

power_IdleSuspend: Allow suspend-to-idle.

Devices that support suspend-to-idle will echo 'freeze' to
/sys/power/state instead of 'mem'.  Make change to support either
string.

Also fixed some pylint docstring failures.

BUG= chromium:627363 
TEST=test_that $dut power_IdleSuspend on device that supports
suspend-to-idle (AKA 'freeze') passes.

Change-Id: I7dd0bd5a7c8e196dd7dce5a0682aadf452a17ed8
Reviewed-on: https://chromium-review.googlesource.com/359615
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/9ffca445edd9e7e2141a66be0b62d4c8ed76e225/client/site_tests/power_IdleSuspend/power_IdleSuspend.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/005f19a373e6bd3eda6c60ea2b32e16e08fd72cf

commit 005f19a373e6bd3eda6c60ea2b32e16e08fd72cf
Author: Todd Broch <tbroch@chromium.org>
Date: Tue Jul 12 06:45:45 2016

power_IdleSuspend: guarantee OOBE completed before suspend.

power manager ignores idle action if OOBE is not completed.  To
guarantee that, control file now runs login_LoginSuccess prior to
executing power_IdleSuspend.

BUG= chromium:627363 
TEST=test_that $dut power_IdleSuspend
No longer raises exception
  'timed out waiting for suspend'
No longer see this log message in powerd log
  '[state_controller.cc(857)] Not performing idle action without OOBE completed'

Change-Id: Idf1484c2767f4fe0ac860360985c02b9bd635023
Reviewed-on: https://chromium-review.googlesource.com/359614
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/005f19a373e6bd3eda6c60ea2b32e16e08fd72cf/client/site_tests/power_IdleSuspend/power_IdleSuspend.py

Comment 4 by tbroch@chromium.org, Jul 15 2016

Fixes in >=8590.0.0

Comment 5 by tbroch@chromium.org, Jul 15 2016

Status: Fixed (was: Started)

Sign in to add a comment