Issue metadata
Sign in to add a comment
|
Regression: Find in page does not get updated when opened after reloading the page.
Reported by
vvishwak...@etouch.net,
Jul 12 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.14 (Official Build) 45a958b687c011d9e28f387ad218ae8878981ecb-refs/branch-heads/2785@{#96} (32/64-bit) OS: Windows (7,8,10), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, go to chrome://settings and press Ctrl+F (to open find bar). 2) Type 'a' in find box and then press F5 key. 3) Again open Find bar, press on Next button and observe. Find box does not get updated on pressing Next button. Find box should get updated on pressing Next button. This is a Regression issue broken in M-46 series, below is the bisect info Manual bisect Good build: 46.0.2478.0 Bad build: 46.0.2480.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/6ca50550a8136fdde5fe87d9fe483826f2f0c74e..ded465bb12ccc7c5bb98a8d0c97ac7087a7955ee?pretty=fuller&n=100 Suspecting: r342718 Note: Issue is not seen on Mac OS.
,
Jul 12 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4490a847784c16a5277604afdfe59b8dae66310d commit 4490a847784c16a5277604afdfe59b8dae66310d Author: estade <estade@chromium.org> Date: Wed Jul 13 17:11:54 2016 Enable find in page buttons based on search text rather than match results. When you re-open the find bar and it's prepopulated with a previous search, we don't execute a search until you press enter or next/previous. Before this patch, next/previous was disabled when you have prepopulated search text but no actual search. BUG= 627356 Review-Url: https://codereview.chromium.org/2143703002 Cr-Commit-Position: refs/heads/master@{#405205} [modify] https://crrev.com/4490a847784c16a5277604afdfe59b8dae66310d/chrome/browser/ui/views/find_bar_view.cc
,
Jul 21 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 12 2016