New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627334 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Android] Touching area out of the canvas triggers click event on the edge of the desktop

Project Member Reported by yuweih@chromium.org, Jul 12 2016

Issue description

Version: ToT
OS: Android 6

What steps will reproduce the problem?
(1) Switch to direct input mode
(2) Touch on the black area outside the canvas

What is the expected output?

Nothing happens

What do you see instead?

The feedback animation shows up and the edge of the desktop is clicked.

Also the long-pressed dragging sometimes doesn't scale correctly.
 

Comment 1 by dah...@chromium.org, Jul 12 2016

Owner: joedow@chromium.org
Status: Assigned (was: Untriaged)
Joe, is this related to the input work you are doing?

Comment 2 by joedow@chromium.org, Jul 12 2016

I think this has been around for awhile but it is occurring in the classes I am updating.  I'll take a look.

Comment 3 by joedow@chromium.org, Jul 12 2016

Status: Started (was: Assigned)
Fixing the touch constraining problem.  A second bug should be filed for the dragging issue since they aren't related.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3697c6003d9a89a17019ab5b72b2ca63349f90

commit 2c3697c6003d9a89a17019ab5b72b2ca63349f90
Author: joedow <joedow@chromium.org>
Date: Wed Jul 13 01:43:20 2016

Preventing touch events from registering when they occur outside the desktop image

We now drop any tap or longpress touch events which occur outside the
image boundaries.  Trackpad mode is not affected as the cursor was
already constrained.

BUG= 627334 

Review-Url: https://codereview.chromium.org/2143813002
Cr-Commit-Position: refs/heads/master@{#404884}

[modify] https://crrev.com/2c3697c6003d9a89a17019ab5b72b2ca63349f90/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Comment 5 by joedow@chromium.org, Jul 13 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)

Comment 6 by joedow@chromium.org, Jul 13 2016

While verifying, can you try the long-press scaling problem and file a bug with repro steps if you have issues?  Thanks!
Status: Verified (was: Fixed)
Verified Fixed. I haven't been able to repro long-press scaling issues on a tablet, but perhaps on the 5x phone its more easily done. 

Comment 8 by yuweih@chromium.org, Jul 27 2016

The long-press dragging issue has actually been fixed in  bug 629686  . Would you verify that? Thanks!

Comment 9 by yuweih@chromium.org, Jul 27 2016

Sorry for pointing to the wrong bug... it should be 628031

Sign in to add a comment