New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627332 link

Starred by 3 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Jul 2016
Cc:
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Pepper graphics stopped working on OSX

Reported by r...@rossis.red, Jul 12 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2793.0 Safari/537.36

Steps to reproduce the problem:
1. Launch game on OSX in the latest Canary 
2. See a black screen

What is the expected behavior?
Graphics render as before (works still on latest Windows 7 Canary).

What went wrong?
[.PPAPIContext]GL ERROR :GL_INVALID_OPERATION : ScopedTextureBinder::dtor: <- error from previous GL command

WebStore page: jbgibbcljlbkkeaogjofolcbakcokmie

Did this work before? Yes Saturday July 9 before Canary auto-updated

Chrome version: 54.0.2793.0  Channel: canary
OS Version: OS X 10.10.4
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by ranjitkan@chromium.org, Jul 12 2016

Cc: ranjitkan@chromium.org
Labels: -Type-Bug -Pri-2 M-54 ReleaseBlock-Beta Pri-1 Type-Bug-Regression
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue and is a regression broken in M54 only on MAC OS. Below are the bisect details for the same:

Bisect info:
============
54.0.2791.0 - G
54.0.2792.0 - B

Change LOG: https://chromium.googlesource.com/chromium/src/+log/9d2d86973416c50f356b737d5787987ae1707a57..7cb1503e57864170612b6a7ad6dc1b8c52907c44

Suspecting change #404496 could be the possible culprit. @erikchen: Request you to please take a look into it. Please help us to reassign to the right owner, if not with respect to your change.

Change URL: https://chromium.googlesource.com/chromium/src/+/c09eb27e67e0fa91bf4be375565a6c6fb5ac9030
Review-Url: https://codereview.chromium.org/2102273002

Adding Release block label, since this is a recent regression. Please undo if not the case.

Thanks.!

Comment 2 by ranjitkan@chromium.org, Jul 12 2016

Labels: has-Bisect

Comment 3 by erikc...@chromium.org, Jul 12 2016 

I'm able to reproduce this issue on my MBP GeForce GT 750M but not on my MacPro ATI Radeon HD 5770.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc766777b27679b88b84561068ef189d550294a

commit 2fc766777b27679b88b84561068ef189d550294a
Author: erikchen <erikchen@chromium.org>
Date: Wed Jul 13 03:14:09 2016

Fix preserve backbuffer with native GMBs.

The implementation of BackTexture::Copy was using glCopyTexImage2D, which
reallocates storage for the BackTexture. This doesn't work with native GMBs,
since they don't use traditional GL storage mechanisms. Switching to
glCopyTexSubImage2D fixes the problem, and is more efficient since storage has
already been allocated.

BUG= 627332 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145643004
Cr-Commit-Position: refs/heads/master@{#404945}

[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_native_gmb_backbuffer_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc766777b27679b88b84561068ef189d550294a

commit 2fc766777b27679b88b84561068ef189d550294a
Author: erikchen <erikchen@chromium.org>
Date: Wed Jul 13 03:14:09 2016

Fix preserve backbuffer with native GMBs.

The implementation of BackTexture::Copy was using glCopyTexImage2D, which
reallocates storage for the BackTexture. This doesn't work with native GMBs,
since they don't use traditional GL storage mechanisms. Switching to
glCopyTexSubImage2D fixes the problem, and is more efficient since storage has
already been allocated.

BUG= 627332 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145643004
Cr-Commit-Position: refs/heads/master@{#404945}

[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/2fc766777b27679b88b84561068ef189d550294a/gpu/command_buffer/tests/gl_native_gmb_backbuffer_unittest.cc

Comment 6 by erikc...@chromium.org, Jul 13 2016

Status: Fixed (was: Assigned)

Comment 7 by r...@rossis.red, Jul 14 2016 

thanks!
►

Sign in to add a comment