New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627311 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Compile failure on chromium.perf Win x64 Builder

Project Member Reported by dtu@chromium.org, Jul 12 2016

Issue description

Hey Fady, looks like your change r404498 caused a compile failure on chromium.perf.

First failing build:
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/builds/10410

Log:
[421/3953] CXX obj/cc/cc_perftests/cc_serialization_perftest.obj
FAILED: obj/cc/cc_perftests/cc_serialization_perftest.obj 
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/cc/cc_perftests/cc_serialization_perftest.obj.rsp /c ../../cc/ipc/cc_serialization_perftest.cc /Foobj/cc/cc_perftests/cc_serialization_perftest.obj /Fd"obj/cc/cc_perftests_cc.pdb"
c:\b\build\slave\win_x64_builder\build\src\mojo\public\cpp\bindings\lib\serialization.h(92): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder\build\src\out\release_x64\gen\cc\ipc\compositor_frame.mojom.h(130): note: see reference to function template instantiation 'bool mojo::internal::StructDeserializeImpl<cc::mojom::CompositorFramePtr,mojo::Array<uint8_t>,UserType>(const DataArrayType &,UserType *)' being compiled
        with
        [
            UserType=cc::CompositorFrame,
            DataArrayType=mojo::Array<uint8_t>
        ]
c:\b\build\slave\win_x64_builder\build\src\cc\ipc\cc_serialization_perftest.cc(119): note: see reference to function template instantiation 'bool cc::mojom::CompositorFrame::Deserialize<cc::CompositorFrame>(const mojo::Array<uint8_t> &,UserType *)' being compiled
        with
        [
            UserType=cc::CompositorFrame
        ]

 
Looks like I can't access the log. Could you please paste in the warning? Thanks! This is a warning that was treated as an error. 

Comment 2 by dtu@chromium.org, Jul 12 2016

Whoops, sorry, missed that.

c:\b\build\slave\win_x64_builder\build\src\mojo\public\cpp\bindings\lib\serialization.h(92): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e092e1f652b5a06a2042e274677ddfa21784ff

commit 36e092e1f652b5a06a2042e274677ddfa21784ff
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Jul 13 02:26:23 2016

mojo: Fix warning (treated as error) on Windows perf bots

BUG= 627311 

Review-Url: https://codereview.chromium.org/2146683002
Cr-Commit-Position: refs/heads/master@{#404911}

[modify] https://crrev.com/36e092e1f652b5a06a2042e274677ddfa21784ff/mojo/public/cpp/bindings/lib/validation_context.cc
[modify] https://crrev.com/36e092e1f652b5a06a2042e274677ddfa21784ff/mojo/public/cpp/bindings/lib/validation_context.h

Comment 5 by dtu@chromium.org, Jul 20 2016

Status: Fixed (was: Assigned)
Thanks!

Comment 6 by dtu@chromium.org, Jul 20 2016

Issue 629284 has been merged into this issue.

Sign in to add a comment