New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627305 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

height is wrong for table cell with box-sizing: border-box

Project Member Reported by dgro...@chromium.org, Jul 12 2016

Issue description

54.0.2793.0 canary (64-bit) shows
h: 86 w: 68 black_h: 50 black_w: 32
FF 50 and Edge show
h: 68 w: 68 black_h: 32 black_w: 32

https://jsfiddle.net/dgrogan/x9pd0t91/

<style type="text/css">
td {
  width: 50px;
  height: 50px;
  padding: 0px;
  box-sizing: border-box;
}
#theDiv {
  height: 100%;
}
</style>
  <table style="border-collapse:collapse" id="theTable">
    <tr style="border:18px solid lightblue" id="row">
      <td><div id="theDiv" style="background:black"></div></td>
    </tr>
</table>
<div id="log"></div>
<script>
window.onload=function(){
log.innerText = "h: " + theTable.offsetHeight + " w: " + theTable.offsetWidth + " black_h: " + theDiv.offsetHeight + " black_w: " + theDiv.offsetWidth; }
</script>
 
Labels: Needs-Bisect
51.0.2704.106 m shows
h: 68 w: 68 black_h: 50 black_w: 32
(Note h: 68 vs 86)

TE team, could you bisect where this behavior changed using the fiddle linked to in the description?
Follow up to comment 1: the old behavior was also incorrect, I'd just like to find out where the behavior changed.

Comment 3 by pxinc...@gmail.com, Jul 12 2016

I'm puzzled
I try it in FireFox.
The result is 
h: 68 w: 86 black_h: 32 black_w: 50.
Which is right ?
comment 3: are you sure? I tried FF 47 on mac and FF 50 on linux and both give the same output:

h: 68 w: 68 black_h: 32 black_w: 32
Cc: brajkumar@chromium.org
Labels: -Type-Bug -Pri-3 -Needs-Bisect M-54 hasbisect OS-Linux OS-Mac OS-Windows Pri-2 Type-Bug-Regression
Owner: robhogan@chromium.org
Status: Assigned (was: Available)
Able to reproduce on Windows 7, Ubuntu 14.04 and Mac OS 10.11.5 using chrome Canary M54-54.0.2793.0.

Bisect Information:
=====================
Good build: 53.0.2782.0 
Bad Build : 53.0.2785.0

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/4fe3fc97d84c8f675bb53a7eb2f6d92903671e02..76dd6b4c688ae32a7a240dcb9da09678472a9e09

From the above change log suspecting below change

Review URL: https://codereview.chromium.org/2075393002

robhogan@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
I'm not sure this was a "regression" because our old behavior was at least partially wrong.
"We'll get there eventually!" :)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1da432b8b1e60df27ed36d2a6439392d2048551e

commit 1da432b8b1e60df27ed36d2a6439392d2048551e
Author: robhogan <robhogan@gmail.com>
Date: Thu Jul 21 05:58:55 2016

Calculate border-box dimensions correctly for cells

When constraining a height on a cell according to box sizing we need to exclude the intrinsic
padding on table cells (calculated to line up the content of the cells with the
baseline of its neighbours) but include any collapsed borders the cells have
picked up from the row/table.

BUG= 627305 

Review-Url: https://codereview.chromium.org/2148513002
Cr-Commit-Position: refs/heads/master@{#406775}

[modify] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[modify] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[add] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/1da432b8b1e60df27ed36d2a6439392d2048551e/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f93d796537bd28f6c22e6d4165ad9846952cd54

commit 0f93d796537bd28f6c22e6d4165ad9846952cd54
Author: robhogan <robhogan@gmail.com>
Date: Wed Aug 31 09:11:12 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

BUG= 637811 , 627305 ,623026, 465096 , 468699 

Review-Url: https://codereview.chromium.org/2296883002
Cr-Commit-Position: refs/heads/master@{#415588}

[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/547803bef371ad6bd9748faa52741e15a4015b6c/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/0f93d796537bd28f6c22e6d4165ad9846952cd54/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79c700b4447ef59138eaa437501c4539f18856d

commit e79c700b4447ef59138eaa437501c4539f18856d
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:14:51 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org

BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309903002 .

Cr-Commit-Position: refs/branch-heads/2785@{#824}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/f72812fd4fc8d47803ecb6921e4e78c762ecf56f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/f72812fd4fc8d47803ecb6921e4e78c762ecf56f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/e79c700b4447ef59138eaa437501c4539f18856d/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 5 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2ee19735711589f6842da1b5f1f1a37072082c

commit ff2ee19735711589f6842da1b5f1f1a37072082c
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:21:52 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:

https://blink.lc/chromium/commit/third_party/WebKit?id=1da432b8b1e60df27ed36d2a6439392d2048551e
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org
BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#157}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Cc: kavvaru@chromium.org
Labels: Needs-Feedback

Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 54.0.2840.14.still observed the output as below.
h: 68 w: 68 black_h: 50 black_w: 33

robhogan@ Please find the attached screen shot and confirm the expected behaviour to verify the issue from our end.

Thanks,
627305.png
75.3 KB View Download

Comment 14 by ajha@chromium.org, Sep 7 2016

Cc: ajha@chromium.org
Below are the observations as tested on Windows-10, Mac OS 10.11.6 and Linux Ubuntu 14.04.

Chrome Stable(53.0.2785.89) Before merge of C#12 CL:
====================================================
h: 86 w: 68 black_h: 50 black_w: 32

Chrome Stable(53.0.2785.101) After merge of C#12 CL:
====================================================
h: 68 w: 68 black_h: 50 black_w: 32

FireFox 48.0.2:
===============
h: 68 w: 68 black_h: 32 black_w: 32

robhogan@: Could you please confirm the correct behavior here and confirm if the latest chrome behavior is working as intended or not?


Didn't test it personally, but 53.0.2785.101 shows what we expect after the reverts were merged to 2785, just comparing comment 14 to comment 1.
dgrogan@, Thank you for the confirmation. We have tested this manually per c#14.
Labels: TE-Verified-M53 TE-Verified-53.0.2785.101
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2ee19735711589f6842da1b5f1f1a37072082c

commit ff2ee19735711589f6842da1b5f1f1a37072082c
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 05 18:21:52 2016

Revert "Percent height content should respect the fixed height of its containing cell"

Revert this CL and its successors. A new approach will be progressed under 637811.

Reverts:

https://blink.lc/chromium/commit/third_party/WebKit?id=1da432b8b1e60df27ed36d2a6439392d2048551e
https://blink.lc/chromium/commit/third_party/WebKit?id=1afb8400a1d933cd50a16947899b0d88d2d30fb0
https://blink.lc/chromium/commit/third_party/WebKit?id=28307938a3f600ff4ade76939ae7c03f617b7df5

TBR=eae@chromium.org
BUG= 637811 , 627305 , 623026 ,465096, 468699

Review URL: https://codereview.chromium.org/2309893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#157}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/fast/table/031-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[delete] https://crrev.com/5ddc18e41ebaedaa158d1ac4293a7ca268270597/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/html/details-writing-mode-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/fast/table/dynamic-descendant-percentage-height-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/core/cell_heights-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt
[modify] https://crrev.com/ff2ee19735711589f6842da1b5f1f1a37072082c/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5243ab8c1a95305aff233a6175aa3a1f94d092f

commit b5243ab8c1a95305aff233a6175aa3a1f94d092f
Author: robhogan <robhogan@gmail.com>
Date: Tue Nov 01 21:07:40 2016

Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG= 637811 , 627305 ,623026, 465096 , 468699 

Review-Url: https://codereview.chromium.org/2441373002
Cr-Commit-Position: refs/heads/master@{#429109}

[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border-on-table.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-collapsed-border.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell-with-padding.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-border-box-sized-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-and-fixed-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-and-fixed-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-with-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell-with-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-fixed-height-content-box-sized-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-content-in-percent-height-cell-with-height-from-row.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-auto-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-auto-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-hidden-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-hidden-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-scroll-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-scroll-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-visible-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-overflow-visible-content-in-cell.html
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-replaced-content-in-cell-expected.txt
[add] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/fast/table/percent-height-replaced-content-in-cell.html
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment