New issue
Advanced search Search tips

Issue 627303 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Sep 2017
Cc:
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add output_all_resource_defines=false to ui/resources/ui_resources.grd

Project Member Reported by thestig@chromium.org, Jul 12 2016 
See  bug 333201  for motivations. I ran it on a trybot and came up with this problem:

IDR_AURA_CURSOR_PTR and friends in ui/resources/ui_resources.grd are defined as <if expr="is_linux and use_aura">, but ui/base/cursor/cursors_aura.cc uses them on many platforms? The trybot failures include Windows and Android. Is cursors_aura.cc just not being properly excluded?
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b9913020f1ba5586afb554c57d788addf981ebf

commit 4b9913020f1ba5586afb554c57d788addf981ebf
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Sep 13 20:20:31 2017

Add output_all_resource_defines=false to ui_resources.grd.

BUG= 627303 

Change-Id: I5bb1e0cdeda3ed637124806cdc9a4f336342f54e
Reviewed-on: https://chromium-review.googlesource.com/664313
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501734}
[modify] https://crrev.com/4b9913020f1ba5586afb554c57d788addf981ebf/ui/base/BUILD.gn
[modify] https://crrev.com/4b9913020f1ba5586afb554c57d788addf981ebf/ui/resources/ui_resources.grd

Comment 2 by thestig@chromium.org, Sep 13 2017

Owner: thestig@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment