New issue
Advanced search Search tips

Issue 627302 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add output_all_resource_defines=false to ui/views/resources/views_resources.grd

Project Member Reported by thestig@chromium.org, Jul 12 2016

Issue description

See  bug 333201  for motivations. Don't remember why I haven't enabled it. Need to run trybots and see.
 
Cc: tapted@chromium.org sadrul@chromium.org
Owner: ----
Linux and Windows trybots fail on https://codereview.chromium.org/2143513003

views_resources.grd has:
<if expr="chromeos">
  <structure type="chrome_scaled_image" name="IDR_MENU_CHECK" file="cros/menu_check.png" />
</if>

but ash/common/system/tray/hover_highlight_view.cc use it on all platforms that use Views. So is it ChromeOS only or not?

Comment 2 by tapted@chromium.org, Jul 13 2016

I guess it should be moved to ash_resources.grd?

Then it will be picked up properly when it's needed for the ash/mus stuff that's built and tested on Windows, but not rolled into the Windows Chrome release.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30

commit 2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Sep 13 20:15:18 2017

Add output_all_resource_defines=false to views_resources.grd

BUG= 627302 

Change-Id: I768475a35a1cefd8d4c0fe3261658803fe14399c
Reviewed-on: https://chromium-review.googlesource.com/664312
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501732}
[modify] https://crrev.com/2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30/ui/views/resources/views_resources.grd

Owner: thestig@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment