Add output_all_resource_defines=false to ui/views/resources/views_resources.grd |
||
Issue descriptionSee bug 333201 for motivations. Don't remember why I haven't enabled it. Need to run trybots and see.
,
Jul 13 2016
I guess it should be moved to ash_resources.grd? Then it will be picked up properly when it's needed for the ash/mus stuff that's built and tested on Windows, but not rolled into the Windows Chrome release.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30 commit 2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30 Author: Lei Zhang <thestig@chromium.org> Date: Wed Sep 13 20:15:18 2017 Add output_all_resource_defines=false to views_resources.grd BUG= 627302 Change-Id: I768475a35a1cefd8d4c0fe3261658803fe14399c Reviewed-on: https://chromium-review.googlesource.com/664312 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#501732} [modify] https://crrev.com/2c4a3a797e5b107e5eb5066c6b0cd35c5f6fdb30/ui/views/resources/views_resources.grd
,
Sep 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Jul 12 2016Owner: ----