New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627296 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: split model out from WI.DOMBreakpointsSidebarPane

Project Member Reported by lushnikov@chromium.org, Jul 12 2016

Issue description

WI.DOMBreakpointsSidebarPane is a single entity which unifies DOMBreakpoints model and widget.

As a result, both sources and elements panels use rely on a single instance of WI.DOMBreakpointsSidebarPane.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38ad51fd7da0f697fef9464ee0af4f9456cedf69

commit 38ad51fd7da0f697fef9464ee0af4f9456cedf69
Author: chenwilliam <chenwilliam@chromium.org>
Date: Thu Aug 25 00:29:44 2016

DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL being set
to the current inspected URL. This CL simplifies the logic for setting the inspected URL
and ensures that the inspected URL is always accurate in the process of restoring breakpoints.

BUG= 627296 

Review-Url: https://codereview.chromium.org/2277543002
Cr-Commit-Position: refs/heads/master@{#414219}

[modify] https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
[modify] https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Components: Platform>DevTools
Status: Fixed (was: Assigned)

Sign in to add a comment