New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627293 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Offline internal page should also show expired pages.

Project Member Reported by romax@chromium.org, Jul 12 2016

Issue description

Add a new column in offline page interal, showing if a page is expired.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2aefd7b797642928a81446a5fa90ddb92584f0

commit bc2aefd7b797642928a81446a5fa90ddb92584f0
Author: romax <romax@chromium.org>
Date: Thu Jul 14 02:40:10 2016

[Offline Pages] Showing expired pages in internal page.

Add a new column in offline internal page showing if a page is expired.

BUG= 627293 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2142703002
Cr-Commit-Position: refs/heads/master@{#405408}

[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/chrome/browser/resources/offline_pages/offline_internals.html
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/chrome/browser/ui/webui/offline_internals_ui.cc
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/components/offline_pages/offline_page_model_impl.h
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/components/offline_pages/stub_offline_page_model.cc
[modify] https://crrev.com/bc2aefd7b797642928a81446a5fa90ddb92584f0/components/offline_pages/stub_offline_page_model.h

Comment 2 by romax@chromium.org, Jul 18 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fixed in Chrome 54.0.2821.0 expired pages are listed now.

Sign in to add a comment