New issue
Advanced search Search tips

Issue 627286 link

Starred by 3 users
Status: Fixed
Owner:
bashi@chromium.org
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDL: remove duplicated typedefs

Project Member Reported by bashi@chromium.org, Jul 11 2016 
Since typedefs have global visibility(*), we should remove duplicated typedefs to avoid a risk of inconsistency.

(*) The current rule is:
- typedefs under core/ can be accessed from core/ and modules/
- typedefs under modules/ can be accessed from modules/
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f23eaf84da1882a8dbf5e3c784f32242c2951a

commit 98f23eaf84da1882a8dbf5e3c784f32242c2951a
Author: bashi <bashi@chromium.org>
Date: Thu Jul 14 03:52:26 2016

IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG= 627286 

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2138673002
Cr-Commit-Position: refs/heads/master@{#405429}

[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/core/dom/CommonDefinitions.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/core/fileapi/File.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/modules/fetch/Body.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.idl

Comment 2 by bashi@chromium.org, Jul 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment