New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627263 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 616183



Sign in to add a comment

Code coverage on Android does not work amnymore

Project Member Reported by infe...@chromium.org, Jul 11 2016

Issue description

Can't get coverage to work on Chrome on Android. Problem looks to be that only sancov.map file is created on |coverage_dir| and no .sancov.raw is created. We kill each individual process matching chrome process name using adb shell kill -9. I don't think kill -9 should matter since we had that previously and also this is memory mapped files.
 
That's because there is no coverage instrumentation.
Even though the builders run with "asan=1 clang=1 sanitizer_coverage=func", the output binaries' export list does not include anything with _cov in the name.
Cc: euge...@chromium.org
Owner: infe...@chromium.org
No, GYP_DEFINES are just for show.
The real work is done by GN, and it does not enable coverage. Buildbot setup needs to be fixed.

Comment 3 by aarya@google.com, Jul 12 2016

Cc: jbudorick@chromium.org agrieve@chromium.org
https://chrome-internal-review.googlesource.com/#/c/269106/. Hopefully edge level coverage should work (after pcc@ optimizations), otherwise, will switch to func level coverage.
:| sorry about that.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/acb10567fd6f5c8831be3c7e885ae61d132d7ef3

commit acb10567fd6f5c8831be3c7e885ae61d132d7ef3
Author: Abhishek Arya <aarya@google.com>
Date: Tue Jul 12 00:46:14 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b75d87b027acce69849f1004d2c3cb522a4c1237

commit b75d87b027acce69849f1004d2c3cb522a4c1237
Author: Abhishek Arya <aarya@google.com>
Date: Tue Jul 12 01:38:16 2016

Comment 7 by aarya@google.com, Jul 12 2016

Status: Fixed (was: Assigned)
Thanks Evgenii for pointing out the issue and John for lightning fast review help.

Sign in to add a comment