New issue
Advanced search Search tips

Issue 627262 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

PDF Generation of Text is Poor on Chromebox

Project Member Reported by skau@chromium.org, Jul 11 2016

Issue description

Version: M52
OS: Chrome OS

What steps will reproduce the problem?
(1) Obtain Chromebox or small laptop
(2) Open page with lots of text e.g. https://www.google.com/intl/en-GB/policies/terms/
(3) Use print dialog to save as pdf

What is the expected output?
pdf rendered as seen on screen

What do you see instead?
poorly rendered text with odd spacing

NOTE: Problem does not reproduce on Pixel 2.  Problem seems to be missing from Windows, Mac, and Linux.
 
TOS_low_dpi.pdf
102 KB Download
PixelGoogleTOS.pdf
133 KB Download
Cc: halcanary@chromium.org
So the two attached PDFs are from different Chrome(OS) versions. Can you try a comparison with the same OS version on both machines?

Comment 3 by skau@chromium.org, Nov 9 2016

I've taken new PDFs on a Kip and Samus running the current Beta build.  The Kip is a test build.

Version information:
Google Chrome	55.0.2883.35 (Official Build) beta (64-bit)
Revision	0
Platform	8872.35.0 (Official Build) beta-channel samus

Google Chrome	55.0.2883.35 (Official Build) unknown (64-bit)
Revision	0
Platform	8872.35.0 (Official Build) dev-channel kip test
SamusTOS.pdf
63.4 KB Download
KipGoogleTOS.pdf
63.0 KB Download
Which is good and which is bad?

KipGoogleTOS has indivifually spaced glyphs, as if the shaper was trying to do sub-pixel hinting.

This may be related to https://crbug.com/640981 .

Comment 5 by skau@chromium.org, Nov 9 2016

KipGoogleTOS is the bad example.  Samus looks better but not fantastic.  Looking at that bug, any chance we're rendering based on screen resolution?
Let's be precise: Blink is positioning glyphs based on the screen resolution.  This is wrong, since the screen resolution is effectively infinite for a PDF.

Comment 7 by skau@chromium.org, Nov 9 2016

That would make sense.  Samus has a much higher DPI than Kip.
If the ratio of the font size to the DPI is high enough, hinting is turned off completely.

Comment 9 by agoode@chromium.org, Nov 17 2016

This explains so much.

Is this a problem in Skia as well, or isolated to Blink?
this is all blink.  BUG=chromium:640981
Components: -Internals>Skia>PDF
Bug 640981 got closed and there was a comment saying PDF generation looked better. Is this still a problem?
This is better, the main issue I see remaining still is  issue 696356 .
skau: Are you happy with the current state of text generation? Are there other bugs that already cover the known issues?

Comment 15 by skau@chromium.org, Mar 14 2017

Status: Fixed (was: Untriaged)
It's significantly improved as far as I can tell.  The letter spacing issue I originally reported is resolved.
Google Terms of Service – Privacy & Terms – Google.pdf
63.1 KB Download

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment