New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627253 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jul 2016
Cc:
penghuang@chromium.org
█ ben@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ChildThreadImpl::AddConnectionFilters can't be called from Init

Project Member Reported by roc...@chromium.org, Jul 11 2016 
Init is called from the constructor, and AddConnectionFilters is virtual. This is no good and leads to e.g. RenderThreadImpl::AddConnectionFilters never actually being called.

This is breaking usage of the UI service from the renderer.

Comment 1 by roc...@chromium.org, Jul 12 2016 

The CL which introduced this bug is being reverted for other reasons. https://codereview.chromium.org/2138263002

I'll merge my fix (https://codereview.chromium.org/2137303002) into it before relanding once I've resolved other issues.

Comment 2 by roc...@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment