SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest is flaky. |
||||||
Issue descriptionFailed build: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/241838 Passed build (same CL): https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/241911 Failing on: [20016:20016:0711/120142:33509545075:FATAL:render_widget_host_impl.cc(1001)] Check failed: !(*is_in_gesture_scroll).
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b0c6f8719ccd5a23cf551b9413d7554673cb802 commit 7b0c6f8719ccd5a23cf551b9413d7554673cb802 Author: kenrb <kenrb@chromium.org> Date: Tue Aug 02 20:03:34 2016 Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG= 631135 , 627238 Review-Url: https://codereview.chromium.org/2193033003 Cr-Commit-Position: refs/heads/master@{#409289} [modify] https://crrev.com/7b0c6f8719ccd5a23cf551b9413d7554673cb802/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/7b0c6f8719ccd5a23cf551b9413d7554673cb802/content/browser/site_per_process_browsertest.cc
,
Aug 3 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b48b70d91ec2dfbf42b53dd72e681305a1800c4 commit 2b48b70d91ec2dfbf42b53dd72e681305a1800c4 Author: timloh <timloh@chromium.org> Date: Wed Aug 03 04:43:18 2016 Disable the flaky test SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest A recent patch https://codereview.chromium.org/2193033003 tried to fix this but it seems to still be flaky. Flaking heavily on linux_chromium_chromeos_ozone_rel_ng and linux_chromium_chromeos_rel_ng. Flaking occasionally on win_chromium_rel_ng, win_chromium_x64_rel_ng, linux_chromium_asan_rel_ng. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests%20(with%20patch)&tests=SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest BUG= 627238 TBR=kenrb@chromium.org Review-Url: https://codereview.chromium.org/2204093002 Cr-Commit-Position: refs/heads/master@{#409456} [modify] https://crrev.com/2b48b70d91ec2dfbf42b53dd72e681305a1800c4/content/browser/site_per_process_browsertest.cc
,
Aug 26 2016
,
Apr 11 2017
After some investigation, I think this is related to an issue with ScrollAnimations: https://bugs.chromium.org/p/chromium/issues/detail?id=710513
,
Apr 13 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e commit 1ed97c2a3c31e85cadfc73b5e775b17571f0656e Author: wjmaclean <wjmaclean@chromium.org> Date: Thu Apr 13 16:30:16 2017 Re-enable OOPIF scroll bubbling test. Scroll animation breaks this test, so re-enable by setting flag on mouse wheel events that disable the animation pathway. We'll need a separate test for the animation pathways at some point. BUG= 627238 NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2818733002 Cr-Commit-Position: refs/heads/master@{#464434} [modify] https://crrev.com/1ed97c2a3c31e85cadfc73b5e775b17571f0656e/content/browser/site_per_process_browsertest.cc
,
Apr 13 2017
Hopefully this is now fixed. Re-open if needed.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75b40615b6c4f91c40120a7b79ae22c5980a05c3 commit 75b40615b6c4f91c40120a7b79ae22c5980a05c3 Author: wjmaclean <wjmaclean@chromium.org> Date: Thu Apr 13 19:55:18 2017 Revert of Re-enable OOPIF scroll bubbling test. (patchset #1 id:1 of https://codereview.chromium.org/2818733002/ ) Reason for revert: We need to land the DCHECK fix in https://codereview.chromium.org/2814043004/ first. Original issue's description: > Re-enable OOPIF scroll bubbling test. > > Scroll animation breaks this test, so re-enable by setting flag on > mouse wheel events that disable the animation pathway. We'll need a > separate test for the animation pathways at some point. > > BUG= 627238 > NO_DEPENDENCY_CHECKS=true > > Review-Url: https://codereview.chromium.org/2818733002 > Cr-Commit-Position: refs/heads/master@{#464434} > Committed: https://chromium.googlesource.com/chromium/src/+/1ed97c2a3c31e85cadfc73b5e775b17571f0656e TBR=avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 627238 Review-Url: https://codereview.chromium.org/2815383002 Cr-Commit-Position: refs/heads/master@{#464515} [modify] https://crrev.com/75b40615b6c4f91c40120a7b79ae22c5980a05c3/content/browser/site_per_process_browsertest.cc
,
Apr 13 2017
Re-opening, until we re-land the CL.
,
Apr 14 2017
Issue 711656 has been merged into this issue.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/417b02487720537a5a57f967ddcd67e09083d236 commit 417b02487720537a5a57f967ddcd67e09083d236 Author: wjmaclean <wjmaclean@chromium.org> Date: Thu Apr 20 15:50:03 2017 Re-enable OOPIF scroll bubbling test, limit to non-animated scroll. This CL re-enables SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest by limiting it to non-scroll animation cases by specifying has_precise_scroll_deltas. The test is still disabled on CrOS due to an unresolved issue with DCHECKs in RenderWidgetHostImpl. BUG= 627238 TBR=creis@chromium.org Review-Url: https://codereview.chromium.org/2826323003 Cr-Commit-Position: refs/heads/master@{#466024} [modify] https://crrev.com/417b02487720537a5a57f967ddcd67e09083d236/content/browser/site_per_process_browsertest.cc
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6076ea0e5caca2693cf84db598b1f33e938720d4 commit 6076ea0e5caca2693cf84db598b1f33e938720d4 Author: wjmaclean <wjmaclean@chromium.org> Date: Mon Apr 24 19:42:47 2017 Re-enable ScrollBubblingFromOOPIFTest on CrOS. This CL re-enables this test on CrOS by fixing a timing issue. BUG= 627238 Review-Url: https://codereview.chromium.org/2830183003 Cr-Commit-Position: refs/heads/master@{#466718} [modify] https://crrev.com/6076ea0e5caca2693cf84db598b1f33e938720d4/content/browser/site_per_process_browsertest.cc
,
Apr 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 12 2016