Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 627234 Refactor Clank Context Menu
Starred by 5 users Project Member Reported by amaralp@chromium.org, Jul 11 2016 Back to list
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 633281

Blocking:
issue 626830
issue 615435



Sign in to add a comment
Issue to track progress on refactoring.

Currently ContentViewCore.java triggers the "cut, copy, paste" menu. This refactor aims to have blink trigger the menu.
 
Components: -Blink UI>Browser
Comment 2 by mustaq@chromium.org, Jul 12 2016
Blocking: 468806
Blockedon: 633281
Blocking: -468806
The mouse event path has been fixed w/o this.
Blocking: 626830
Blocking: 615435
Project Member Comment 8 by bugdroid1@chromium.org, Mar 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f88569b6a113509e7e7245ca297221701d07d4a3

commit f88569b6a113509e7e7245ca297221701d07d4a3
Author: amaralp <amaralp@chromium.org>
Date: Thu Mar 02 07:28:26 2017

Make SelectionPopupController.ShowPastePopup only be triggered by Blink

This patch is progress towards the goal of having Blink triggering all
of clank's SelectActionMode context menus. In particular this patch
has Blink trigger the menu when an insertion handle is tapped or
dragged.

BUG=627234

Review-Url: https://codereview.chromium.org/2721813002
Cr-Commit-Position: refs/heads/master@{#454203}

[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/f88569b6a113509e7e7245ca297221701d07d4a3/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Project Member Comment 9 by bugdroid1@chromium.org, Mar 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5687419f74d3767023162b603ac08b2a998dc6

commit 7a5687419f74d3767023162b603ac08b2a998dc6
Author: amaralp <amaralp@chromium.org>
Date: Thu Mar 02 20:01:24 2017

Revert of Make SelectionPopupController.ShowPastePopup only be triggered by Blink (patchset #3 id:40001 of https://codereview.chromium.org/2721813002/ )

Reason for revert:
Caused flakiness (crbug.com/697934)

Original issue's description:
> Make SelectionPopupController.ShowPastePopup only be triggered by Blink
>
>
> This patch is progress towards the goal of having Blink triggering all
> of clank's SelectActionMode context menus. In particular this patch
> has Blink trigger the menu when an insertion handle is tapped or
> dragged.
>
> BUG=627234
>
> Review-Url: https://codereview.chromium.org/2721813002
> Cr-Commit-Position: refs/heads/master@{#454203}
> Committed: https://chromium.googlesource.com/chromium/src/+/f88569b6a113509e7e7245ca297221701d07d4a3

TBR=aelias@chromium.org,boliu@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627234

Review-Url: https://codereview.chromium.org/2727203003
Cr-Commit-Position: refs/heads/master@{#454355}

[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/7a5687419f74d3767023162b603ac08b2a998dc6/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Project Member Comment 10 by bugdroid1@chromium.org, Mar 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c8279c96ec0483bfc86fddd66a860db2dccae18

commit 8c8279c96ec0483bfc86fddd66a860db2dccae18
Author: amaralp <amaralp@chromium.org>
Date: Tue Mar 21 20:05:53 2017

Make SelectionPopupController.ShowPastePopup only be triggered by Blink

This patch is progress towards the goal of having Blink triggering all
of clank's SelectActionMode context menus. In particular this patch
has Blink trigger the menu when an insertion handle is tapped or
dragged.

BUG=627234

Review-Url: https://codereview.chromium.org/2721813002
Cr-Original-Commit-Position: refs/heads/master@{#454203}
Committed: https://chromium.googlesource.com/chromium/src/+/f88569b6a113509e7e7245ca297221701d07d4a3
Review-Url: https://codereview.chromium.org/2721813002
Cr-Commit-Position: refs/heads/master@{#458525}

[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/8c8279c96ec0483bfc86fddd66a860db2dccae18/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Sign in to add a comment