New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627204 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make discover throw exceptions when it detects duplicate keys indexed by class name

Project Member Reported by nedngu...@google.com, Jul 11 2016

Issue description

We want this to avoid subtle bugs like  issue 615134  which telemetry fails to run a benchmark because there is another benchmark with same class name in the same directory. 

Announcement in https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/i6FlJJDFWQA
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 12 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a579f48e9c2266a5e0751ddb6e7ecf41accaa653

commit a579f48e9c2266a5e0751ddb6e7ecf41accaa653
Author: nednguyen <nednguyen@google.com>
Date: Tue Jul 12 14:25:37 2016

[content/test/gpu] Rename cloud_storage_test_base.TestBase to cloud_storage_test_base.CloudStorageTestBase

This class currently has the same name with gpu_test_base.TestBase which
will cause breakage once https://codereview.chromium.org/2075743002/ is landed.

NOTRY=true
BUG= 627204 

Review-Url: https://codereview.chromium.org/2136773002
Cr-Commit-Position: refs/heads/master@{#404809}

[modify] https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653/content/test/gpu/gpu_tests/cloud_storage_test_base.py
[modify] https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653/content/test/gpu/gpu_tests/gpu_rasterization.py
[modify] https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653/content/test/gpu/gpu_tests/maps.py
[modify] https://crrev.com/a579f48e9c2266a5e0751ddb6e7ecf41accaa653/content/test/gpu/gpu_tests/pixel.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83fd009eff1f4278bf8a3322f16e3ab7beace26

commit b83fd009eff1f4278bf8a3322f16e3ab7beace26
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Jul 15 04:52:07 2016

Roll src/third_party/catapult/ 581af8674..b8c7ec593 (3 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/581af8674af7..b8c7ec593d79

$ git log 581af8674..b8c7ec593 --date=short --no-merges --format='%ad %ae %s'

BUG= 627204 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2150843004
Cr-Commit-Position: refs/heads/master@{#405701}

[modify] https://crrev.com/b83fd009eff1f4278bf8a3322f16e3ab7beace26/DEPS

Components: Tests>Telemetry
Owner: nedngu...@google.com
Status: Fixed (was: Untriaged)

Sign in to add a comment