False positives in `git cl lint` IWYU |
||
Issue descriptiongit cl lint will flag any use of "base::hash_map" as if it were "std::hash_map" and suggest to add #include <hash_map> to fix this. std::string already has some logic to omit the suggestion if it is used in non-STL namespaces, so the same check should be OK to use for other types.
,
Jul 12 2016
Upstream CL https://github.com/google/styleguide/pull/158 Chromium CL https://codereview.chromium.org/2147593002/
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9b2173c4190b8fc39db3ed15e7281411013ce986 commit 9b2173c4190b8fc39db3ed15e7281411013ce986 Author: lhchavez <lhchavez@chromium.org> Date: Wed Jul 13 17:20:07 2016 Make build/include_what_you_use more consistent This is a cherry-pick of https://github.com/google/styleguide/pull/158/ BUG= 627202 TEST=cpplint_unittest.py Review-Url: https://codereview.chromium.org/2147593002 [modify] https://crrev.com/9b2173c4190b8fc39db3ed15e7281411013ce986/cpplint.py
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/d9ea5928b8763fedce712da9afdbd5a69c6c6935 commit d9ea5928b8763fedce712da9afdbd5a69c6c6935 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 17:26:31 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/9b2173c4190b8fc39db3ed15e7281411013ce986 Make build/include_what_you_use more consistent (lhchavez@chromium.org) R=lhchavez@chromium.org BUG= 627202 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2152513002 [modify] https://crrev.com/d9ea5928b8763fedce712da9afdbd5a69c6c6935/infra/config/recipes.cfg
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/d9ea5928b8763fedce712da9afdbd5a69c6c6935 commit d9ea5928b8763fedce712da9afdbd5a69c6c6935 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 17:26:31 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/9b2173c4190b8fc39db3ed15e7281411013ce986 Make build/include_what_you_use more consistent (lhchavez@chromium.org) R=lhchavez@chromium.org BUG= 627202 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2152513002 [modify] https://crrev.com/d9ea5928b8763fedce712da9afdbd5a69c6c6935/infra/config/recipes.cfg
,
Jul 13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2b764906cf4bbc0a529a668a70139886d6e13953 commit 2b764906cf4bbc0a529a668a70139886d6e13953 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 17:38:48 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/0156739ddb4fb894b36b5b0385e40ac7a513986c commit 0156739ddb4fb894b36b5b0385e40ac7a513986c Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 18:08:53 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/d9ea5928b8763fedce712da9afdbd5a69c6c6935 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/62cd25edb19ac96af36aa939f032974cb97fc190 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/9b2173c4190b8fc39db3ed15e7281411013ce986 Make build/include_what_you_use more consistent (lhchavez@chromium.org) https://crrev.com/2d1b6dae5acc5c7580668a1d8e12e33c46774782 Support C++11 types in build/include_what_you_use (lhchavez@chromium.org) R=lhchavez@chromium.org,phajdan.jr@chromium.org,martiniss@chromium.org,recipe-roller@chromium.org BUG= 627514 , 627202 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2146603004 [modify] https://crrev.com/0156739ddb4fb894b36b5b0385e40ac7a513986c/infra/config/recipes.cfg
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c266ae372af8fff6fc0ef7255edab5e6d5453bd4 commit c266ae372af8fff6fc0ef7255edab5e6d5453bd4 Author: lhchavez <lhchavez@chromium.org> Date: Wed Jul 13 20:15:43 2016 Remove a now unneeded NOLINT Now that cpplint.py doesn't trigger a false positive with base::hash_map, we don't need the NOLINT tag anymore. BUG= 627202 TEST=git cl lint # clean output Review-Url: https://codereview.chromium.org/2146833003 Cr-Commit-Position: refs/heads/master@{#405263} [modify] https://crrev.com/c266ae372af8fff6fc0ef7255edab5e6d5453bd4/chrome/browser/memory/tab_manager_delegate_chromeos.h
,
Jul 15 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by lhchavez@chromium.org
, Jul 12 2016Status: Started (was: Untriaged)