Currently it only tries once, making whole jobs fail for a transient blip. (such as cloud endpoints proxy serving 404s occasionally) The code for the client this bug refers to resides in: https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/client/cmd/buildbucket/
please use https://godoc.org/github.com/luci/luci-go/common/retry for retries
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/4172212f34db48ecc02aab897fcf38246ccf5682 commit 4172212f34db48ecc02aab897fcf38246ccf5682 Author: nodir <nodir@chromium.org> Date: Tue Aug 09 23:26:27 2016 Update bulidbucket client - Move to //buildbucket - Add retries - Simplify, in particular do not unmarshal and then re-marshal responses - add doc.go - consolidate isLocalHost funcs R=vadimsh@chromium.org, robertocn@chromium.org BUG= 627199 Review-Url: https://codereview.chromium.org/2227113002 [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/README.md [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/base_command.go [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/cancel.go [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/client.go [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/doc.go [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/get.go [rename] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/main.go [add] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/buildbucket/client/cmd/buildbucket/put.go [delete] https://crrev.com/a378372c6df34157270be5ed1db126e3f07dda3d/client/cmd/buildbucket/base_command.go [delete] https://crrev.com/a378372c6df34157270be5ed1db126e3f07dda3d/client/cmd/buildbucket/cancel.go [delete] https://crrev.com/a378372c6df34157270be5ed1db126e3f07dda3d/client/cmd/buildbucket/get.go [delete] https://crrev.com/a378372c6df34157270be5ed1db126e3f07dda3d/client/cmd/buildbucket/put.go [modify] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/common/lhttp/utils.go [modify] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/dm/appengine/distributor/jobsim/run.go [modify] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/dm/tools/dmtool/vizQuery.go [modify] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/grpc/cmd/rpc/main.go [modify] https://crrev.com/4172212f34db48ecc02aab897fcf38246ccf5682/logdog/client/butler/output/logdog/output.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/99496cd7b046e0dd321919e5682d9d79d58f7f0c commit 99496cd7b046e0dd321919e5682d9d79d58f7f0c Author: nodir <nodir@chromium.org> Date: Thu Aug 11 22:09:07 2016 Roll infra/go/src/github.com/luci/luci-go/ 9380f91eb..ea3fb670b (22 commits). https://chromium.googlesource.com/external/github.com/luci/luci-go/+log/9380f91ebb16..ea3fb670b4fa $ git log 9380f91eb..ea3fb670b --date=short --no-merges --format='%ad %ae %s' 2016-08-11 nodir cipd: move to root 2016-08-10 vadimsh auth: Update code that checks delegation tokens. 2016-08-10 dnj descutil: Use constants for runtime tag values. 2016-08-09 iannucci Make EnsureQuestData able to calculate Quest IDs for raw quest descriptions. 2016-08-09 iannucci Remove verbose log message from tumble 2016-08-09 iannucci Rename NewJSONObject to match the type that it actually generates. 2016-08-09 iannucci Add Transient and ExtractData to errors, remove MaybeLogError. 2016-08-09 iannucci Add -C option to PRESUBMIT pcg invocation. 2016-08-09 dnj LogDog: Return better than 500 on invalid project. 2016-08-09 iannucci Speed up tumble test under race detector. 2016-08-09 nodir Update bulidbucket client 2016-08-08 vadimsh auth: Add internal 'tokenCache' class. 2016-08-08 iannucci Fix context bug in svcdec. 2016-08-08 vadimsh auth: Allow auth library to use memcache interface. 2016-08-08 nodir prpc: clarify protocol 2016-08-08 maruel Convert isolatedclient to non-proxied endpoints. 2016-08-06 vadimsh auth: Add GetAuthServiceURL to authdb.DB interface. 2016-08-06 iannucci Add some utility methods and package constants to isolated*. 2016-08-06 iannucci Add log callback generator method to retry. 2016-08-06 iannucci Make cryptorand and mathrand's context keys more self-explanatory 2016-08-06 iannucci Make memlock less verbose. 2016-08-05 vadimsh auth: Move AuthDB related code into auth/authdb subpackage. R=vadimsh@chromium.org BUG= 627199 Review-Url: https://codereview.chromium.org/2239093002 [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/DEPS [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/build/README.md [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/build/build.py [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/build/packages/buildbucket.yaml [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/build/packages/cipd_client.yaml [modify] https://crrev.com/99496cd7b046e0dd321919e5682d9d79d58f7f0c/go/src/infra/tools/cloudtail/cmd/cloudtail/main.go
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/4084bea06ebd9535a4da6c1e01e853d4b083d73c commit 4084bea06ebd9535a4da6c1e01e853d4b083d73c Author: Nodir Turakulov <nodir@google.com> Date: Fri Aug 12 00:05:35 2016
deployed
Comment 1 by no...@chromium.org
, Jul 11 2016