New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627195 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
█ tbreisacher@chromium.org
dbeam@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Closure: it's too easy to compile/break our closure bots with the wrong Java{,c} version

Project Member Reported by dbeam@chromium.org, Jul 11 2016 
It's really easy for contributors to Closure Compilation to compile and commit a roll without any good way of knowing it'll break all of the try/FYI bots we run.  This is because of Java version incompatibilities.  Everything builds and runs locally for them, the CQ/try bots can't handle binary files, so a manual land is required.

This can break all our FYI and try bots, grinding a bit to a halt:
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux
https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation

I'm going to at least add a small check in our roll_closure_compiler bash script.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384105b95e25f71a1598cb6ebcb75e381668bd9f

commit 384105b95e25f71a1598cb6ebcb75e381668bd9f
Author: dbeam <dbeam@chromium.org>
Date: Mon Jul 11 19:52:02 2016

Closure: enforce Java version in roll script

R=dpapad@chromium.org
BUG= 627195 

NOTRY=true

Review-Url: https://codereview.chromium.org/2137233002
Cr-Commit-Position: refs/heads/master@{#404709}

[modify] https://crrev.com/384105b95e25f71a1598cb6ebcb75e381668bd9f/third_party/closure_compiler/roll_closure_compiler

Comment 2 by dbeam@chromium.org, Jul 11 2016

Cc: dbeam@chromium.org
Owner: ----
Status: Available (was: Started)
i'll leave this open for now, but comment 1 probably helps a bit

Comment 3 by dbeam@chromium.org, Jul 11 2016

Labels: -Pri-1 Pri-2
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dbeam@chromium.org, Jul 12 2017

Status: Fixed (was: Untriaged)
this is actually fixed with a Maven target now, I think

Comment 6 by dbeam@chromium.org, Jul 12 2017 

as in: there's some tag we added that targets a specific version of Java to build for (i.e. target Java 7 or something)
►

Sign in to add a comment