New issue
Advanced search Search tips

Issue 627161 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add an experiment group to ParseHTMLOnMainThread that tokenizes synchronously in response to IPC

Project Member Reported by csharrison@chromium.org, Jul 11 2016

Issue description

This may regress performance, but it is worthwhile to look at if we're getting descheduled on the main thread for the normal experiment group.

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f

commit 2fcf4bab78301b1c7b64b1b47547e7e5a70da65f
Author: csharrison <csharrison@chromium.org>
Date: Wed Jul 13 05:03:39 2016

Add an experiment group via Settings to tokenize synchronously

This patch adds an experiment group that tokenizes synchronously
on the main thread in response to a recieve data IPC.

If this regresses performance, we can augment the CL slightly
to only synchronously tokenize when the main parser has no
work.

BUG= 627161 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2139703003
Cr-Commit-Position: refs/heads/master@{#405035}

[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f

commit 2fcf4bab78301b1c7b64b1b47547e7e5a70da65f
Author: csharrison <csharrison@chromium.org>
Date: Wed Jul 13 05:03:39 2016

Add an experiment group via Settings to tokenize synchronously

This patch adds an experiment group that tokenizes synchronously
on the main thread in response to a recieve data IPC.

If this regresses performance, we can augment the CL slightly
to only synchronously tokenize when the main parser has no
work.

BUG= 627161 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2139703003
Cr-Commit-Position: refs/heads/master@{#405035}

[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f

commit 2fcf4bab78301b1c7b64b1b47547e7e5a70da65f
Author: csharrison <csharrison@chromium.org>
Date: Wed Jul 13 05:03:39 2016

Add an experiment group via Settings to tokenize synchronously

This patch adds an experiment group that tokenizes synchronously
on the main thread in response to a recieve data IPC.

If this regresses performance, we can augment the CL slightly
to only synchronously tokenize when the main parser has no
work.

BUG= 627161 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2139703003
Cr-Commit-Position: refs/heads/master@{#405035}

[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/2fcf4bab78301b1c7b64b1b47547e7e5a70da65f/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Comment 6 by dimu@google.com, Jul 14 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 14 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/057f6fd414cb7f11a3d70a28380304293216abf8

commit 057f6fd414cb7f11a3d70a28380304293216abf8
Author: csharrison <csharrison@chromium.org>
Date: Thu Jul 14 17:42:11 2016

Remove threading primitives from ParseHTMLOnMainThread

This patch removes locks from ParsedChunkQueue, and use
of crossThreadBind in HTMLDocumentParser/BackgroundHTMLParser,
which introduces unecessary copies if we're not actually crossing
threads.

BUG= 627198 

Review-Url: https://codereview.chromium.org/2134323002
Cr-Commit-Position: refs/heads/master@{#405139}
(cherry picked from commit 0b4376118260f28c64433db1002e23ed8c663cb0)

Add an experiment group via Settings to tokenize synchronously

This patch adds an experiment group that tokenizes synchronously
on the main thread in response to a recieve data IPC.

If this regresses performance, we can augment the CL slightly
to only synchronously tokenize when the main parser has no
work.

BUG= 627161 

Review-Url: https://codereview.chromium.org/2139703003
Cr-Commit-Position: refs/heads/master@{#405035}
(cherry picked from commit 2fcf4bab78301b1c7b64b1b47547e7e5a70da65f)

NOPRESUBMIT=true
TBR=kouhei@chromium.org,kinuko@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2150973002
Cr-Commit-Position: refs/branch-heads/2785@{#115}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.cpp
[modify] https://crrev.com/057f6fd414cb7f11a3d70a28380304293216abf8/third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.h

Status: Fixed (was: Started)

Sign in to add a comment