New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627154 link

Starred by 3 users
Status: Fixed
Owner:
davidben@chromium.org
Closed: Jul 2017
Cc:
kroot@google.com
davidben@chromium.org
█ joth@chromium.org
█ digit@chromium.org
█ jnd@chromium.org
█ pliard@chromium.org
█ bdc@google.com
rsleevi@chromium.org
█ felipeg@chromium.org
pasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cert_verify_proc_android.cc should not hard-code authentication type

Project Member Reported by davidben@chromium.org, Jul 11 2016 
https://cs.chromium.org/chromium/src/net/cert/cert_verify_proc_android.cc?rcl=0&l=36

I don't think it matters because Android seems to ignore it altogether, but we should route the type through. In theory Android could decide to check key usage from it.

Comment 1 by rsleevi@chromium.org, Jul 11 2016

Status: Available (was: Untriaged)
Marking available, but very tempted to just outright WontFix so we don't have a zombie bug.

This was the official recommendation of the Android team (and as an API has, unfortunately, 'rusted shut' due to third-parties). 

I agree that it's not inconceivable that the Android team may decide to break this in the future, but that's a significant break, especially considering Android can't really check key usages given its environment constraints.

Comment 2 by davidben@chromium.org, Jul 11 2016 

Ah. In that case we should have a comment that Android officially recommends not to bother with that field rather than a TODO.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e3a683655be19279d1059ea1c9a62568a270226

commit 6e3a683655be19279d1059ea1c9a62568a270226
Author: David Benjamin <davidben@chromium.org>
Date: Thu Jul 06 14:59:09 2017

Remove TODO.

See comment #1 on associated bug.

Bug:  627154 
Change-Id: Ic32630ddda478593d1b6f5524579e65a47561eaf
Reviewed-on: https://chromium-review.googlesource.com/560149
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484593}
[modify] https://crrev.com/6e3a683655be19279d1059ea1c9a62568a270226/net/cert/cert_verify_proc_android.cc

Comment 4 by davidben@chromium.org, Jul 6 2017

Owner: davidben@chromium.org
Status: Fixed (was: Available)

Comment 5 by rsleevi@chromium.org, Jul 6 2017

Labels: M-61

Comment 6 by davidben@chromium.org, Dec 13

Cc: felipeg@chromium.org jnd@chromium.org davidben@chromium.org pliard@chromium.org digit@chromium.org pasko@chromium.org kroot@google.com bdc@google.com rsleevi@chromium.org joth@chromium.org
 Issue 162720  has been merged into this issue.
►

Sign in to add a comment