New issue
Advanced search Search tips

Issue 627145 link

Starred by 2 users
Status: Fixed
Owner:
pdr@chromium.org
Closed: Jul 2016
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 524134



Sign in to add a comment

Object fit tests fail in spv2

Project Member Reported by pdr@chromium.org, Jul 11 2016 
Any test that uses object fit will fail in spv2 because the clip is not applied.

Some examples:
fast/css/object-position-with-fit-contain.html [ Failure ]
fast/css/object-position-with-fit-cover.html [ Failure ]
fast/css/object-position-with-fit-none.html [ Failure ]
fast/css/object-position.html [ Failure ]
fast/css/object-fit-img.html [ Failure ]
fast/css/object-fit-input-image.html [ Failure ]
fast/css/object-fit-object.html [ Failure ]
fast/css/object-fit-shrink.html [ Failure ]
fast/css/object-fit-video-poster.html [ Failure ]
fast/css/object-fit-embed.html [ Failure ]
fast/css/object-fit-grow-landscape.html [ Failure ]
fast/css/object-fit-grow-portrait.html [ Failure ]

Comment 1 by chrishtr@chromium.org, Jul 12 2016

Blocking: 524134
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4

commit e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4
Author: pdr <pdr@chromium.org>
Date: Wed Jul 13 05:00:32 2016

Adjust src and dest rects when drawing images instead of using a clip

This patch removes a clip recorder in ImagePainter and VideoPainter
and simply adjusts the rects passed to GraphicsContext::drawImage. This
also fixes several tests using spv2 which were not applying the
spv1-only clip.

There's a minor resampling artifact on three tests which, regrettably,
must be turned into pixel tests.

BUG= 627145 

Review-Url: https://codereview.chromium.org/2134253002
Cr-Commit-Position: refs/heads/master@{#405033}

[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.txt
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.txt
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.txt
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/ImagePainter.h
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/VideoPainter.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd80e552f779f177a3249f2f90065eea5cdbbccc

commit bd80e552f779f177a3249f2f90065eea5cdbbccc
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Jul 13 06:30:33 2016

Auto-rebaseline for r405033

https://chromium.googlesource.com/chromium/src/+/e7678ecd5

BUG= 627145 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2145913002 .

Cr-Commit-Position: refs/heads/master@{#405059}

[modify] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/android/fast/css/object-fit-grow-landscape-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/android/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/compositing/img-layer-object-fit-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-landscape-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-portrait-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-portrait-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-portrait-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-portrait-expected.txt
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4

commit e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4
Author: pdr <pdr@chromium.org>
Date: Wed Jul 13 05:00:32 2016

Adjust src and dest rects when drawing images instead of using a clip

This patch removes a clip recorder in ImagePainter and VideoPainter
and simply adjusts the rects passed to GraphicsContext::drawImage. This
also fixes several tests using spv2 which were not applying the
spv1-only clip.

There's a minor resampling artifact on three tests which, regrettably,
must be turned into pixel tests.

BUG= 627145 

Review-Url: https://codereview.chromium.org/2134253002
Cr-Commit-Position: refs/heads/master@{#405033}

[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.txt
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-landscape-expected.txt
[delete] https://crrev.com/f430907071c83ca6ade8297e8167a165416f2bd4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.html
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/LayoutTests/fast/css/object-fit-grow-portrait-expected.txt
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/ImagePainter.cpp
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/ImagePainter.h
[modify] https://crrev.com/e7678ecd5f7c5bbdbfb78df2d8269a79e06236d4/third_party/WebKit/Source/core/paint/VideoPainter.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd80e552f779f177a3249f2f90065eea5cdbbccc

commit bd80e552f779f177a3249f2f90065eea5cdbbccc
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Jul 13 06:30:33 2016

Auto-rebaseline for r405033

https://chromium.googlesource.com/chromium/src/+/e7678ecd5

BUG= 627145 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2145913002 .

Cr-Commit-Position: refs/heads/master@{#405059}

[modify] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/compositing/img-layer-object-fit-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/android/fast/css/object-fit-grow-landscape-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/android/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/compositing/img-layer-object-fit-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-landscape-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-portrait-expected.png
[rename] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/linux/fast/css/object-fit-grow-portrait-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/mac/fast/css/object-fit-grow-portrait-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/compositing/img-layer-object-fit-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-landscape-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-landscape-expected.txt
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-portrait-expected.png
[add] https://crrev.com/bd80e552f779f177a3249f2f90065eea5cdbbccc/third_party/WebKit/LayoutTests/platform/win/fast/css/object-fit-grow-portrait-expected.txt

Comment 6 by pdr@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment