New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627143 link

Starred by 33 users
Status: Started
Owner:
drott@chromium.org
Cc:
vamshi.kommuri@chromium.org
█ krajshree@chromium.org
pnangunoori@chromium.org
behdad@chromium.org
█ sandeepkumars@chromium.org
kojii@chromium.org
nyerramilli@chromium.org
ksakamoto@chromium.org
wfh@chromium.org
jsc...@chromium.org
ligim...@chromium.org
█ msrchandra@chromium.org
e...@chromium.org
toyoshim@chromium.org
█ rsheeter@google.com
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 828317


Sign in to add a comment

@font-face src: local() should take *font face* name, not *family* name

Reported by carlo.st...@gmail.com, Jul 11 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. apt-get install ttf-sjfonts
2. run the attached file (test.html).

What is the expected behavior?
Chromium should use the local font.

What went wrong?
It uses a network resource (the WOFF file).

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 51.0.2704.79  Channel: beta
OS Version: Debian Stretch (testing)
Flash Version: 

By removing "url('SteveHand.woff')" Chromium uses properly the local file: see the attached file (test2.html).
SteveHand.woff
42.5 KB Download
test.html
212 bytes View Download
test2.html
189 bytes View Download

Comment 1 by chrishtr@chromium.org, Jul 11 2016

Components: -Blink Blink>Loader Blink>Fonts
It does load the URL from the network, but that doesn't mean that it's
necessarily blocking on or using the network one. Sending to the loading team.

Comment 2 by e...@chromium.org, Jul 12 2016

Components: -Blink>Fonts Blink>WebFonts

Comment 3 by toyoshim@chromium.org, Jul 13 2016

Status: Available (was: Unconfirmed)
I checked if the request was triggered for pre-load/fetch, but this was triggered by CSSFontFaceSrcValue.

Also, I checked if local font was used to render contents by running under a slow network emulation, but this load blocked rendering and used system font when it hit timeout.

If the network request returns an error, it uses the local font. So, something looks wrong around font selection.

Comment 4 by toyoshim@chromium.org, Jul 13 2016

Labels: -Pri-2 Needs-Feedback Pri-3
Status: Unconfirmed (was: Available)
In CSSFontFace::load(), source->isLoadFontAvailable() returns false because the font name is different.

% fc-list|grep SteveHand.ttf
/usr/share/fonts/truetype/sjfonts/SteveHand.ttf: Steve:style=Hand

So the right name to use with local() is not SteveHand but Steve.
I modified test.html to specify "src: local('Steve'), url('SteveHand.woff');" and it works fine.

If the reporter agreed, I'll close this as WontFix.

Comment 5 by carlo.st...@gmail.com, Jul 13 2016 

Hi,
thank you for your reply.

There are some things I don't understand.

1) If I put "src: local('Steve');" Firefox doesn't find the font; is this a Firefox bug?
2) If I put "src: local('SteveHand');" Chromium *finds* the font (is this a bug?). Why with "src: local('SteveHand'), url('SteveHand.woff');" it has a different behavior?

Thank you very much!
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 13 2016

Labels: -Needs-Feedback Needs-Review
Owner: toyoshim@chromium.org
Thank you for providing more feedback. Adding requester "toyoshim@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by toyoshim@chromium.org, Jul 14 2016

Labels: -Needs-Review Needs-Feedback
1) I think so.

2) This isn't a bug.

In test2.html, Chrome also can not recognize local('SteveHand'). After that, Chrome tried to search a font with font-family name 'Steve', then find it.

You can confirm this by modifying test2.html as follows.

a) src: local('NotFound');

b) font-family: 'FooBar'; (in two places)

Even with change a), Chrome can find the font. But with change b), Chrome cannot.

Comment 8 by carlo.st...@gmail.com, Jul 15 2016 

Clear, thank you very much!

I've just opened a bug report for Firefox:

https://bugzilla.mozilla.org/show_bug.cgi?id=1287089

Best regards,
Carlo
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 15 2016

Labels: -Needs-Feedback Needs-Review
Thank you for providing more feedback. Adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by carlo.st...@gmail.com, Jul 15 2016 

Please look at this answer:

https://bugzilla.mozilla.org/show_bug.cgi?id=1287089#c1

Thanks!

Comment 11 Deleted

Comment 12 by toyoshim@chromium.org, Jul 16 2016 

Thanks. It seems our side needs to check implementation again.

Comment 13 by csharrison@chromium.org, Jul 18 2016

Owner: toyoshim@chromium.org
toyoshim, do you mind owning this?

Comment 14 by csharrison@chromium.org, Jul 18 2016

Status: Assigned (was: Unconfirmed)

Comment 15 by carlo.st...@gmail.com, Jul 18 2016 

 Issue 578275  might be related; it should be reopened, IMHO.

Comment 16 by toyoshim@chromium.org, Jul 19 2016

Cc: toyoshim@chromium.org
Owner: e...@chromium.org
I heard eae@ might be familiar with font selection.
Let me assign eae@ first.

eae@
As Jonathan mentioned at bugzilla, src:local() takes font face name which may be either the "full name" or "postscript name".
[1] https://www.w3.org/TR/css-fonts-3/#src-desc

But, it looks Chrome handle it is a font family name when it search local fonts.

Comment 17 by toyoshim@chromium.org, Jul 19 2016 

 Issue 578275  has been merged into this issue.

Comment 18 by toyoshim@chromium.org, Jul 19 2016

Components: Blink>Fonts

Comment 19 by ksakamoto@chromium.org, Sep 20 2016

Cc: ksakamoto@chromium.org
 Issue 648108  has been merged into this issue.

Comment 20 by pdk...@gmail.com, Sep 20 2016 

From the merged bug.

http://cdn.pwmon.org/chrome/bug.html

In Ubuntu, this shows the problem without having to install fonts.

Comment 21 by ksakamoto@chromium.org, Sep 20 2016

Components: -Blink>Loader

Comment 22 by pdk...@gmail.com, Oct 1 2016 

I think this affects Android too, as Noto Serif is pre-loaded on Android M, yet is still downloaded.

Comment 23 by e...@chromium.org, Nov 1 2016

Cc: e...@chromium.org drott@chromium.org
Owner: ----
Status: Available (was: Assigned)
Summary: @font-face src: local() should take *font face* name, not *family* name (was: [CSS] @font-face src: local() doesn't work properly)

Comment 24 by drott@chromium.org, Nov 1 2016

Cc: behdad@chromium.org

Comment 25 by drott@chromium.org, Nov 1 2016 

Looking at the spec for local():

https://drafts.csswg.org/css-fonts/#descdef-src
"For OpenType and TrueType fonts, this string is used to match only the Postscript name or the full font name in the name table of locally available fonts."

Where "full font name" namerecord ID 4 from 
http://www.microsoft.com/Typography/OTSpec/name.htm

Carlo, does that match your expectation for "face name"?

Comment 26 by drott@chromium.org, Nov 1 2016

Cc: rsheeter@google.com

Comment 27 by e...@chromium.org, Nov 1 2016 

Also look at the gecko reply in comment 10.

Comment 28 by pdk...@gmail.com, Jan 29 2017 

Still in M56.

Comment 29 by drott@chromium.org, Feb 16 2017

Cc: krajshree@chromium.org wfh@chromium.org jsc...@chromium.org
 Issue 690334  has been merged into this issue.

Comment 30 by drott@chromium.org, Feb 16 2017

Owner: drott@chromium.org
Status: Assigned (was: Available)

Comment 31 by drott@chromium.org, Feb 16 2017

Cc: kojii@chromium.org
 Issue 586914  has been merged into this issue.

Comment 32 by ksakamoto@chromium.org, Feb 22 2017 

 Issue 694135  has been merged into this issue.

Comment 33 Deleted

Comment 34 by noeff...@gmail.com, Jul 25 2017 

Uninstalling EVGA's Precision XOC application appears to have fixed it.  

Seems like that program, which is completely unrelated to chrome, somehow overrides the windows font settings in some way.

Comment 35 by drott@chromium.org, Nov 8 2017

Cc: ligim...@chromium.org sandeepkumars@chromium.org nyerramilli@chromium.org msrchandra@chromium.org pnangunoori@chromium.org
 Issue 782255  has been merged into this issue.

Comment 36 by drott@chromium.org, Dec 15 2017 

 Issue 792271  has been merged into this issue.

Comment 37 by b...@keeptalkinggame.com, Jan 11 2018 

Another data point: this affects the CSS provided by fonts.googleapis.com causing locally installed fonts to be ignored.

Example:
Chrome: 63.0.3239.132 
OS: Windows 10

Linking "http://fonts.googleapis.com/css?family=Special+Elite"

Returns this CSS:
/* latin */
@font-face {
  font-family: 'Special Elite';
  font-style: normal;
  font-weight: 400;
  src: local('Special Elite Regular'), local('SpecialElite-Regular'), url(http://fonts.gstatic.com/s/specialelite/v8/9-wW4zu3WNoD5Fjka35JmzxObtw73-qQgbr7Be51v5c.woff2) format('woff2');
  unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2212, U+2215;
}

The src correctly references the font face name. Chrome does not find the locally installed font and falls back to using the web font. Firefox does find the locally installed font.

If you modify the CSS to reference local('Special Elite') (i.e. the font family name), then the behaviour is reversed: Chrome finds the local font and Firefox does not.

Comment 38 by drott@chromium.org, Mar 22 2018

Status: Started (was: Assigned)

Comment 39 by e...@chromium.org, Mar 23 2018

Cc: vamshi.kommuri@chromium.org
 Issue 822011  has been merged into this issue.

Comment 40 by e...@chromium.org, Mar 23 2018 

 Issue 824589  has been merged into this issue.

Comment 41 by drott@chromium.org, Apr 3 2018

Blockedon: 828317

Comment 42 by drott@chromium.org, May 28 2018 

 Issue 845259  has been merged into this issue.

Comment 43 by foolip@chromium.org, Sep 28

Labels: Hotlist-Interop
Project Member

Comment 44 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8e7c130cbb432732e973fd8c266a0608727b5f

commit 2e8e7c130cbb432732e973fd8c266a0608727b5f
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Jan 14 15:06:36 2019

Enable unique font matching matching by default

Now that all implementations for Android, Windows, Linux/CrOS and Mac
are in place, enable the feature globally. Chrome will match fonts
references in @font-face { src: local(<font-name>) } correctly by
postscript name or full font name. This addresses a long standing,
highly starred font matching issue in Chrome.

Bug: 828317, 627143,  921029 
Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
Reviewed-on: https://chromium-review.googlesource.com/c/1400695
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622456}
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/content/public/common/content_features.cc
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-character-fallback.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-download-error.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/text/capitalize-boundaries.html
[add] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/fast/text/unique-vs-family-match.html
[modify] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
[add] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
[add] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
[add] https://crrev.com/2e8e7c130cbb432732e973fd8c266a0608727b5f/third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

Comment 45 by drott@chromium.org, Jan 14

Status: Fixed (was: Started)
All implementations landed, flag switched on by default. This is now fixed, modulo waiting for UMA data on how fast the font table is built on Windows.
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e

commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e
Author: Dominik Röttsches <drott@chromium.org>
Date: Wed Jan 16 00:08:23 2019

Revert "Enable unique font matching matching by default"

This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.

Reason for revert: Crashes observed in Windows Canary

Bug: 922183

Original change's description:
> Enable unique font matching matching by default
> 
> Now that all implementations for Android, Windows, Linux/CrOS and Mac
> are in place, enable the feature globally. Chrome will match fonts
> references in @font-face { src: local(<font-name>) } correctly by
> postscript name or full font name. This addresses a long standing,
> highly starred font matching issue in Chrome.
> 
> Bug: 828317, 627143,  921029 
> Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622456}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 828317, 627143,  921029 
Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
Reviewed-on: https://chromium-review.googlesource.com/c/1412824
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622898}
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/content/public/common/content_features.cc
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-character-fallback.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-download-error.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/fast/text/capitalize-boundaries.html
[delete] https://crrev.com/286a6a456f744bc4e41a4e9f7037aefcdb18ff61/third_party/blink/web_tests/fast/text/unique-vs-family-match.html
[modify] https://crrev.com/f6c717eb8b60f311b6357b3ddace4c79b1a2e64e/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
[delete] https://crrev.com/286a6a456f744bc4e41a4e9f7037aefcdb18ff61/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/286a6a456f744bc4e41a4e9f7037aefcdb18ff61/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/286a6a456f744bc4e41a4e9f7037aefcdb18ff61/third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

Comment 47 by drott@chromium.org, Jan 16

Status: Started (was: Fixed)
Project Member

Comment 48 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f

commit 1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f
Author: Dominik Röttsches <drott@chromium.org>
Date: Wed Jan 16 11:36:33 2019

Reland "Enable unique font matching matching by default"

This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e.

Reason for revert: Crash has been addressed in 
https://chromium-review.googlesource.com/c/chromium/src/+/1414852

Original change's description:
> Revert "Enable unique font matching matching by default"
> 
> This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.
> 
> Reason for revert: Crashes observed in Windows Canary
> 
> Bug: 922183
> 
> Original change's description:
> > Enable unique font matching matching by default
> > 
> > Now that all implementations for Android, Windows, Linux/CrOS and Mac
> > are in place, enable the feature globally. Chrome will match fonts
> > references in @font-face { src: local(<font-name>) } correctly by
> > postscript name or full font name. This addresses a long standing,
> > highly starred font matching issue in Chrome.
> > 
> > Bug: 828317, 627143,  921029 
> > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> > Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622456}
> 
> TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 828317, 627143,  921029 
> Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
> Reviewed-on: https://chromium-review.googlesource.com/c/1412824
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622898}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922183, 828317, 627143,  921029 , 922183
Reviewed-on: https://chromium-review.googlesource.com/c/1413603
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623199}
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/content/public/common/content_features.cc
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-character-fallback.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-download-error.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/text/capitalize-boundaries.html
[add] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/fast/text/unique-vs-family-match.html
[modify] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
[add] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
[add] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
[add] https://crrev.com/1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f/third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

Comment 49 by drott@chromium.org, Jan 16

Status: Fixed (was: Started)
This was relanded => Setting to fixed again.
Project Member

Comment 50 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e747504f7caf471e94acc4916864790517e40c

commit 09e747504f7caf471e94acc4916864790517e40c
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jan 18 14:37:47 2019

Revert "Reland "Enable unique font matching matching by default""

This reverts commit 1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f.

Reason for revert: 
* Preliminary Windows font table lookup build times look too high
* Time to first paint affected on some lower end Android tests 

Original change's description:
> Reland "Enable unique font matching matching by default"
> 
> This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e.
> 
> Reason for revert: Crash has been addressed in 
> https://chromium-review.googlesource.com/c/chromium/src/+/1414852
> 
> Original change's description:
> > Revert "Enable unique font matching matching by default"
> > 
> > This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.
> > 
> > Reason for revert: Crashes observed in Windows Canary
> > 
> > Bug: 922183
> > 
> > Original change's description:
> > > Enable unique font matching matching by default
> > > 
> > > Now that all implementations for Android, Windows, Linux/CrOS and Mac
> > > are in place, enable the feature globally. Chrome will match fonts
> > > references in @font-face { src: local(<font-name>) } correctly by
> > > postscript name or full font name. This addresses a long standing,
> > > highly starred font matching issue in Chrome.
> > > 
> > > Bug: 828317, 627143,  921029 
> > > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> > > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > > Reviewed-by: Avi Drissman <avi@chromium.org>
> > > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#622456}
> > 
> > TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 828317, 627143,  921029 
> > Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
> > Reviewed-on: https://chromium-review.googlesource.com/c/1412824
> > Reviewed-by: Dominik Röttsches <drott@chromium.org>
> > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622898}
> 
> TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> 
> Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 922183, 828317, 627143,  921029 , 922183
> Reviewed-on: https://chromium-review.googlesource.com/c/1413603
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623199}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 922183, 828317, 627143,  921029 , 923245,  922495 , 922941
Change-Id: I27efa4f06148c2fc58d7feb5f15f48623713a570
Reviewed-on: https://chromium-review.googlesource.com/c/1421099
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624117}
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/content/public/common/content_features.cc
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-character-fallback.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-download-error.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/fast/text/capitalize-boundaries.html
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/fast/text/unique-vs-family-match.html
[modify] https://crrev.com/09e747504f7caf471e94acc4916864790517e40c/third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
[delete] https://crrev.com/16c9e690685282e3e5d61b393347352b9507e6cd/third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

Comment 51 by drott@chromium.org, Jan 18 (5 days ago)

Status: Started (was: Fixed)
Reopenend, UMA data on Windows shows that table build time can be quite taxing on some systems.
►

Sign in to add a comment