Issue metadata
Sign in to add a comment
|
Browser crashes if you click on an extension's Details link |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.4 OS: ChromeOS What steps will reproduce the problem? (1) Open chrome://extensions (2) Pick the first extension (mine is something called "Android Bug Tool") and hit Details. What is the expected output? Expect to see details of the extension, e.g. manifest, etc. What do you see instead? Browser crashes (see 46b226b600000000 or c6db7e0200000000, though because of issue 610902 they are not symbolized. I filed a very similar-sounding bug against GMail recently ( issue 623275 ), so once we have crash stacks we should compare.
,
Jul 11 2016
Repros 100% reliably -> RB-Beta. Still an issue in ChromeOS 54.0.2792.0 build, FWIW.
,
Jul 11 2016
ChromeOS 54.x crash-ID: 4346c10200000000 (sadly still no symbols).
,
Jul 12 2016
Could repro this on Enrolled Device M ChromeOS Chrome ARC Type Channel 53 8530.10.0 53.0.2785.10 3026157 release dev
,
Jul 12 2016
,
Jul 12 2016
,
Jul 12 2016
,
Jul 12 2016
,
Jul 13 2016
,
Jul 13 2016
+khmel Think this is the crash: [17504:17504:0713/084511:FATAL:arc_auth_service.cc(637)] Check failed: profile_. #0 0x7f1c1927ae3e base::debug::StackTrace::StackTrace() #1 0x7f1c192d307c logging::LogMessage::~LogMessage() #2 0x7f1c1c9d004d arc::ArcAuthService::IsArcEnabled() #3 0x7f1c1c112271 AppInfoDialog::AppInfoDialog() #4 0x7f1c1c111c46 ShowAppInfoInNativeDialog() #5 0x7f1c1d260037 extensions::ShowPermissionsDialogHelper::Show() #6 0x7f1c1d23bee9 extensions::api::DeveloperPrivateShowPermissionsDialogFunction::Run() Happens on non arc enabled devices, where --enable-arc is not present and ArcAuthService does not have a proper |profile_|.
,
Jul 13 2016
Proper check should be arc_auth_service->IsAllowed() && arc_auth_service->IsArcEnabled()
,
Jul 13 2016
I will fix this, found one more place with danger usage.
,
Jul 13 2016
,
Jul 16 2016
Would it make sense to have IsArcEnabled require IsAllowed, rather than patching up lots of call sites? It seems that if it's not "allowed" then it really isn't "enabled".
,
Jul 18 2016
Yes, it is done in CL: https://codereview.chromium.org/2149853004/
,
Jul 18 2016
,
Jul 19 2016
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b937b462197e87d4ac0c44c0275b7a5350963c0 commit 4b937b462197e87d4ac0c44c0275b7a5350963c0 Author: khmel <khmel@chromium.org> Date: Tue Jul 19 17:58:33 2016 arc: Implement safe access to ArcAuthService. TEST=Extended browser_tests TEST=Manually on device with Arc enabled/disabled. BUG= 627137 Review-Url: https://codereview.chromium.org/2149853004 Cr-Commit-Position: refs/heads/master@{#406307} [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/arc/arc_auth_service.h [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/arc/arc_support_host.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/arc/arc_support_host.h [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc [modify] https://crrev.com/4b937b462197e87d4ac0c44c0275b7a5350963c0/components/user_manager/user_manager_base.cc
,
Jul 29 2016
Do not see fix in the latest available build.Is it not yet merged? M ChromeOS Chrome ARC Type Channel 53 8530.35.0 53.0.2785.36 3102164 release beta
,
Jul 29 2016
,
Jul 29 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 29 2016
,
Jul 29 2016
Keeping the bug opened as the merging is in progress.
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2ae94d69130233a271a36971b7a27f0f6ae8d08 commit b2ae94d69130233a271a36971b7a27f0f6ae8d08 Author: Luis Hector Chavez <lhchavez@google.com> Date: Mon Aug 01 15:36:39 2016 [Merge to M53] arc: Implement safe access to ArcAuthService. TEST=Extended browser_tests TEST=Manually on device with Arc enabled/disabled. BUG= 627137 Review-Url: https://codereview.chromium.org/2149853004 Cr-Commit-Position: refs/heads/master@{#406307} (cherry picked from commit 4b937b462197e87d4ac0c44c0275b7a5350963c0) R=afakhry@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/2201493002 . Cr-Commit-Position: refs/branch-heads/2785@{#431} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/arc/arc_auth_service.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/arc/arc_auth_service.h [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/arc/arc_support_host.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/arc/arc_support_host.h [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc [modify] https://crrev.com/b2ae94d69130233a271a36971b7a27f0f6ae8d08/components/user_manager/user_manager_base.cc
,
Aug 4 2016
Fixed checked in to 53.0.2785.42. Marking this Fixed, to be verified in M53.
,
Aug 4 2016
Working in M53,Enguarde device.No crashes observed. M ChromeOS Chrome ARC Type Channel 53 8530.43.0 53.0.2785.47 3117197 release beta
,
Aug 12 2016
Issue 635230 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Jul 11 2016