New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627133 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Robohornet test suite reportedly crashing Chrome

Project Member Reported by rsch...@chromium.org, Jul 11 2016

Issue description

Press reports that running Robohornet on Windows 10 in Chrome 51 crashes the tab
http://www.zdnet.com/article/whats-the-best-and-worst-browser-for-windows-10/

I was able to reproduce this on Chrome 51.0.2704.106 64-bit. Crash ID is 60c1c6b600000000 and the crash occurs in blink::ShapeCache::addSlowCase.

Emil, can you help triage?
 
Labels: M-51

Comment 2 by e...@chromium.org, Jul 12 2016

Status: Assigned (was: Unconfirmed)
Given that I wrote both the test harness and the code the crashes this falls firmly on me. I'll take a look.

Comment 3 by e...@chromium.org, Jul 12 2016

Labels: Needs-Feedback
Can't get it to crash on either stable or canary on windows 10. Do you happen to know which test cases a crash?
Descendant selector crashes reliably and immediately for me. More crash IDs:

6a09e30900000000
8a11e30900000000
6059e30900000000

Not the same function, but various font functions.

Comment 5 by e...@chromium.org, Jul 13 2016

Interesting. Thank you.

All crashes are EXCEPTION_STACK_OVERFLOW. Not sure why it would cause a stock overflow all of a sudden though!

Comment 6 by mlr...@gmail.com, Aug 22 2016

Happens only on Chrome x64.
Chrome x86 (running on win10 x64) runs the test fine.

Comment 7 by wfh@chromium.org, Aug 22 2016

lots of nested layout happening in these stacks. 64-bit has less stack space as the frames are larger, so could explain this happening only on that platform.

Is the page being rendered very complex with lots of deep nested html elements?

Comment 8 by e...@chromium.org, Aug 22 2016

Lots of deeply nested elements, yes. This might be WAI.

Comment 9 by wfh@chromium.org, Aug 22 2016

Labels: Needs-Bisect
I can confirm this causes a crash on stable 52.0.2743.116 (Official Build) m (64-bit) but it doens't on Canary 54.0.2835.0 (Official Build) canary (64-bit)

So I think this needs a bisect.

Comment 10 by mlr...@gmail.com, Aug 22 2016

Depth of 1000 nodes. 
See http://www.robohornet.org/tests/descendantselector.html source

Comment 11 by e...@chromium.org, Aug 22 2016

Status: WontFix (was: Assigned)
Right. The combination of the reduced stack space on 64bit and the increase in call stack depth due to text shaping pushes us over the limit.

LayoutNG will fix this by not having a recursive layout implementation but until then there isn't much we can do I'm afraid.

Thanks for your help wfh & mlregs.

Sign in to add a comment