Themes can make tabs partially transparent, should be forced to opaque
Reported by
t.ma...@gmail.com,
Jul 11 2016
|
|||||||||||||
Issue description
Chrome Version : 51.0.2704.103
OS Version: 8172.60.0
URLs (if applicable) : N/A
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5: N/A
Firefox 4.x: N/A
IE 7/8/9: N/A
Some tab titles are rendered in a garbled way, but some are just fine. See attached screenshots.
I use Tamil as the UI language; not sure if that's a causing/helping this issue. Also, mine is a HP Chrombook 13 G1 (with a 3200×1800 screen). Not sure if the issue is specific to this hardware model.
UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8172.60.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
,
Jul 21 2016
,
Jul 22 2016
uhhh this looks like the bg tabs are for some reason not fully opaque. This messes up the text because of subpixel anti aliasing onto a non-opaque bg. Pretty sure your screenshots show you're using a custom theme. Which one is it? This is likely another place we need to force the theme-provided color to opaque.
,
Jul 22 2016
Yeah, that's definitely the result of rendering text onto a transparent background. As Evan notes, this is presumably due to a custom there -- let us know which one you're using.
,
Jul 22 2016
I am using 'Space Lagoon' theme: https://chrome.google.com/webstore/detail/space-lagoon/balmhbonohcljflhinodkindpfmcdlie PS: Took me a while to find out which theme I am currently using. This post was useful: https://productforums.google.com/d/msg/chrome/QwiuHnwOk1U/Kl4Ko2mVAJMJ
,
Jul 22 2016
thanks. I don't see this on Linux 51 or 53 so it's likely cros-specific (would be worth checking win and Mac). Peter if you can't repro on win feel free to re-assign to me.
,
Jul 22 2016
Indeed; I'm also not seeing the issue on Linux. I looked up the theme ID on my Linux box since it's a bit easier.
,
Jul 23 2016
Doesn't reproduce on my Win 10 Dev build. But does reproduce on my Chromebook that's on M53. So it looks like this is an unfixed, CrOS-specific bug. I don't know what would be CrOS-specific about this. I'll try to debug a little locally on Windows to see where the tab color is being forced to opaque.
,
Jul 23 2016
Retargeting CCs at more appropriate people.
,
Jul 23 2016
Part of the issue is that the theme provides a custom IDR_THEME_FRAME, but it's not used on my Windows 10 machine because ShouldWindowContentsBeTransparent() is true -- in other words, the theme isn't forcing us onto the old opaque frame. So the background tabs are drawn as tinted versions of the (opaque) toolbar color. I suspect this may reproduce on Win 7 in classic mode, and if so, it would suggest that it's because both that and CrOS treat the window contents as "not transparent", so we'd use the custom frame image, so the background tabs would become copies of that background image tinted with TINT_BACKGROUND_TAB. I bet the background image has a non-opaque alpha channel in it and that's the issue? Not really sure. Do we have a tool to unpack theme .pak files and play around with their contents? It's really annoying to be trying to figure all this out inside a debugger.
,
Jul 23 2016
Hmm. I can't repro if I hack the code locally to force the opaque frame on. So I guess I don't know why this is occurring. I think someone is going to have to debug on CrOS and figure out what's up. I elect Terry.
,
Oct 30 2016
Hi! I'm also having this issue with with the last version of Chrome OS (stable channel), using a theme I have developed. If you need any help to find out what's causing this, I can send you the theme's manifest. BTW, before this happened to me only when I did not have the Chrome window maximized, but since Chrome 53 (I don't remember which version, but more or less) it happens in all windows. I can't reproduce this problem in MacOS/OS X.
,
Jan 28 2017
Hi again! This issue hasn't been solved yet. Is there any update on it? Also, is there any way I can help get this problem solved? Thanks ;)
,
Aug 9 2017
Tom/Omri, can you please help to triage this issue?
,
Aug 10 2017
Stéphane, it seems we have a problem with anti alising text on semi-transparent backgrounds, I've also seen this recently on the Launcher. Is there anything we can do here?
,
Aug 10 2017
This is probably more appropriate for Vlad's team
,
Aug 10 2017
Chatted with marcheu@ offline, it looks like this could be from anywhere in the stack which could be any of many different teams :-/ If this only happens on ChromeOS, it's likely in Aura.
,
Aug 10 2017
the issue with blurry subpixel text rendering onto non-opaque backgrounds is long standing and had long been understood to be unfixable. The way we would fix it in this case is either to force bg tabs to be opaque (ignore the alpha channel that the theme provides) or to disable subpixel AA on tab text when we detect that this will be a problem.
,
Aug 16 2017
Omri, I need you help figuring out how to approach this.
,
Aug 1
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by cbiesin...@chromium.org
, Jul 21 2016